Possible variable re-use

[mujuonly]

The variable $spam is defined in the line 2228 in wp-includes/user.php and we can re-use the same variable in the line 2463 and 2646

The variable $spam is set above in the function like $spam = empty( $userdata['spam'] ) ? 0 : (bool) $userdata['spam']; We can re-use the variable instead of checking again as the specific key in the $userdata array is not getting changed.

Trac ticket: https://core.trac.wordpress.org/ticket/58152

[SergeyBiryukov]

Thanks for the PR!

It looks like the purpose of the $spam variable here is to be included in the compact() call in line 2330​.

Reading the DocBlock above the suggested change​, it makes it immediately clear what $userdata is: the raw array of data passed to wp_insert_user(), and $userdata['spam'] is a part of that array. This naming also seems more consistent when being compared with $old_user_data->spam.

If we replace it with $spam, anyone reviewing the code would then have to spend some more time to find where that variable is defined.

So I don't see any benefits in changing this code, it seems fine as is to me.