Media Tests for Attachments and Images

[Howdy_McGee]

The attached patch adds PHPUnit Tests to the following functions:

• wp_get_attachment_url()
• wp_get_attachment_metadata()
• image_downsize()
• get_image_tag()
• image_get_intermediate_size()
• wp_get_attachment_image_src()
• wp_get_attachment_image()

The tests are straight-forward and ensures that they are working as expected.

[Howdy_McGee]

Unit Tests

[mukesh27]

Hi @Howdy_McGee, Thanks for the ticket and patch. Can you please open a PR against the ​https://github.com/WordPress/wordpress-develop/ repo so it will be easier to check the exiting tests and newly added tests in different PHP versions?

Also Quick review for the patch. Add ticket number in tests which you have added.

I could not see an active github user account for Howdy_McGee, so I created a PR for them.

https://core.trac.wordpress.org/ticket/58163

[kebbet]

A total novice at tests, but test_get_image_tag_empty_src is failing. Is the test written corectly? Can get_image_tag have an empty src attribute?

[Howdy_McGee]

@kebbet Thank you for creating a PR and testing the patch!

Looking at the ​`get_image_tag()` source, it looks like it does return an image tag with an empty src attribute. Whether it should do that is an entirely different question.

I've run these tests on PHP 5.6, 7.4, and 8.0 and haven't logged any issues. Could you share the specific errors that your system is logging and the PHP version you're using?

[kebbet]

The linked Pull Request at GitHub runs the test suit on commit, so linking to the latest test results, failures on PHP 8.1 and PHP 8.2.

​https://github.com/WordPress/wordpress-develop/actions/runs/4754147962

There was 1 error:

1) Tests_Media::test_get_image_tag_empty_src
ltrim(): Passing null to parameter #1 ($string) of type string is deprecated

/var/www/src/wp-includes/formatting.php:4392
/var/www/src/wp-includes/media.php:396
/var/www/tests/phpunit/tests/media.php:4038
/var/www/vendor/bin/phpunit:123