WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#58182 closed enhancement (fixed)

Use esc_url in default_password_nag()

Reported by: utsav72640 Owned by: audrasjb
Priority: normal Milestone: 6.3
Component: Users Version: 2.8
Severity: normal Keywords: has-patch commit
Cc: Focuses: coding-standards

Description

esc_url missing on wp-admin/includes/user.php file

Attachments (1)

user_patch_file.patch​ (831 bytes ) - added by utsav72640 3 years ago.
esc_url missing on wp-admin/includes/user.php file

Download all attachments as: .zip

Change History (9)

@utsav72640
3 years ago

esc_url missing on wp-admin/includes/user.php file

#1 @utsav72640
3 years ago

Also I have added in git a new pull request can you please check and let me know if there are any changes or not.

​https://github.com/WordPress/wordpress-develop/pull/4372

#2 @utsav72640
3 years ago

  • Version → 6.2

#3 @mukesh27
3 years ago

  • Keywords has-patch added; dev-feedback removed
  • Milestone Awaiting Review → 6.3
  • Summary esc_url missing on wp-admin/includes/user.php file → Use esc_url in default_password_nag()
  • Type defect (bug) → enhancement
  • Version 6.2 → 2.8

#4 @mukesh27
3 years ago

Hi there!

Thanks for ticket and PR! PR look good to me and approved.

@SergeyBiryukov can you please take a look.

#5 @audrasjb
3 years ago

  • Component General → Users
  • Keywords commit added

Hello and thanks for the ticket and patch,

As the result of get_edit_profile_url() can be filtered, let's escape it properly.

This ticket was mentioned in ​PR #4372 on ​WordPress/wordpress-develop by ​utsavtilava.
3 years ago #6

esc_url missing on wp-admin/includes/user.php file

EDIT by @audrasjb: trac ticket: https://core.trac.wordpress.org/ticket/58182

#7 @audrasjb
3 years ago

  • Owner set to audrasjb
  • Resolution → fixed
  • Status new → closed

In 55682:

Coding Standards: Escape edit profile URL in default_password_nag().

Props utsav72640, mukesh27.
Fixes #58182.

Note: See TracTickets for help on using tickets.