WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 6 years ago

Last modified 6 years ago

#5819 closed defect (bug) (fixed)

comments rss feed - namespace hook missing / feed invalid if link in comment-text

Reported by: neoxx Owned by:
Milestone: 2.8 Priority: normal
Severity: normal Version: 2.3.3
Component: Feeds Keywords: has-patch tested commit
Focuses: Cc:

Description

hi folks!

during a customizing-session i noticed, that we miss the namespace-hook (i would suggest commentrss2_ns) in wp-includes/feed-rss2-comments.php.

moreover i checked my current feed with http://www.feedvalidator.org/ and found out that the comments-feed doesn't validate, if there is a link in a comment (perhaps of the no-follow attribute?). can anyone verify that behaviour?

berny

Attachments (3)

5819.diff.txt (586 bytes) - added by neoxx 7 years ago.
5819.diff (487 bytes) - added by neoxx 7 years ago.
5819.2.diff (477 bytes) - added by Denis-de-Bernardy 6 years ago.
make the do_action consistent with what happens in atom

Download all attachments as: .zip

Change History (13)

comment:1 @lloydbudd7 years ago

  • Keywords feeds rss comment feeds added

comment:2 @lloydbudd7 years ago

berny, thanks for participating in WordPress! One issue per ticket please.

@neoxx7 years ago

@neoxx7 years ago

comment:3 @neoxx7 years ago

the attached diff should solve the namespace-problem.

further, i opened a new ticket for the second issue http://trac.wordpress.org/ticket/6187 (valid comment feeds).

berny

comment:4 @Nazgul7 years ago

  • Keywords has-patch added
  • Milestone changed from 2.6 to 2.5

@Denis-de-Bernardy6 years ago

make the do_action consistent with what happens in atom

comment:5 @Denis-de-Bernardy6 years ago

  • Component changed from General to Feeds
  • Keywords tested commit added; feeds rss comment feeds removed
  • Milestone changed from 2.9 to 2.8
  • Owner anonymous deleted

comment:6 @westi6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [11279]) Add a 'rss2_comments_ns' action to the namespaces section of the RSS2 comments feed. Fixes #5819.

comment:7 follow-up: @Denis-de-Bernardy6 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

@westi: in this case, we should also rename the one in the atom comments, for consistency.

comment:8 in reply to: ↑ 7 @westi6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

Replying to Denis-de-Bernardy:

@westi: in this case, we should also rename the one in the atom comments, for consistency.

Please don't reopen tickets for different issues.

If you think this is worth changing raise a new ticket

comment:9 @Denis-de-Bernardy6 years ago

will, do, but in the future, it would help if you wondered why I don't go for the obvious (which I agree is rss2_comments_ns in this case) in the first place. especially when I give the reason in the patch's comment: make the do_action consistent with what happens in atom.

Note: See TracTickets for help on using tickets.