WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #58202, comment 22


Ignore:
Timestamp:
07/17/2023 07:39:00 PM (3 years ago)
Author:
azaozz
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #58202, comment 22

    initial v1  
    55> It seems like because it's a public method, the route would be to remove setting the time limit by default, but leave the ability to do so?
    66
    7 Yea, sounds reasonable. Although thinking it may also be good to deprecate `set_imagick_time_limit()` and even maybe "disable" it (just trigger deprecation notice and return). The the default [https://github.com/ImageMagick/ImageMagick/blob/a8de149e1aca79836319b31c8881537115e478ff/MagickCore/resource.c#L1283C70-L1283C70 processing time limit] in ImageMagick is "infinity". Don't see why WP should be changing that or even have a method to change it.
     7Yea, sounds reasonable. Although thinking it may also be good to deprecate `set_imagick_time_limit()` and even maybe "disable" it (just trigger deprecation notice and return). The the default [https://github.com/ImageMagick/ImageMagick/blob/a8de149e1aca79836319b31c8881537115e478ff/MagickCore/resource.c#L1283C70-L1283C70 processing time limit] in ImageMagick is "infinity", ideally PHP's timeout should be something similar when running imagick, not the other-way round? :)
     8Seeing the bugs above don't think WP should be changing that or even have a method to change it.
    89
    910I'll just commit the deprecation for now, but lets remove the functionality if all agree.