Changes between Initial Version and Version 1 of Ticket #58206, comment 12
- Timestamp:
- 05/02/2023 07:56:37 PM (3 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #58206, comment 12
initial v1 1 1 I have "mixed feelings" about this. Imho replacing `false === strpos( ... )` and `false !== strpos( ... )` with `str_contains()` is premature. 2 2 3 The problem is that only ~20% of the current WP sites are on PHP 8+. So 80% will have to use the polyfill. Then the question is: is that polyfill faster thanthe native PHP 7.4 code? I did a quick comparison and it seems about 280% slower:3 The problem is that only ~20% of the current WP sites are on PHP 8+. So 80% will have to use the polyfill. Then the question is: how much slower is the polyfill compared to the native PHP 7.4 code? I did a quick comparison and it seems about 280% slower: 4 4 5 5 {{{