WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#58207 closed enhancement (fixed)

Code Modernization/Performance optimization: Replace `dirname(__FILE__)` with `__DIR__`

Reported by: hztyfoon Owned by: SergeyBiryukov
Priority: normal Milestone: 6.3
Component: General Version:
Severity: normal Keywords: has-patch
Cc: Focuses: performance, coding-standards

Description

in wp-admin/options-privacy.php file line number 17:
​https://github.com/WordPress/wordpress-develop/blob/250250d35ede7402cf474a0f439d7f6c992dd7d7/src/wp-admin/options-privacy.php#L17
dirname( __FILE__ ) can be replaced with __DIR__ magic constant.

Check ticket: #48082
check this commit: ​https://github.com/wordpress/wordpress-develop/commit/e72fff9ceffb41d22c48febfc5f97c0cd46f5884

Change History (4)

This ticket was mentioned in ​PR #4387 on ​WordPress/wordpress-develop by ​@rudlinkon.
3 years ago #1

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/58207

#2 @SergeyBiryukov
3 years ago

  • Milestone Awaiting Review → 6.3

#3 @SergeyBiryukov
3 years ago

  • Owner set to SergeyBiryukov
  • Resolution → fixed
  • Status new → closed

In 55691:

Coding Standards: Use __DIR__ magic constant in wp-admin/options-privacy.php.

This replaces the only remaining instance of dirname( __FILE__ ) in core to avoid the performance overhead of a function call.

Follow-up to [47198], [50161], [50631].

Props hztyfoon, rudlinkon.
Fixes #58207.

​@SergeyBiryukov commented on ​PR #4387:
3 years ago #4

Thanks for the PR! Merged in r55691.

Note: See TracTickets for help on using tickets.