Make WordPress Core

#58209 closed defect (bug) (fixed)

Add missing 'view_items' label to the 'wp_block' post type

Reported by: afercia's profile afercia Owned by: afercia's profile afercia
Milestone: 6.3 Priority: normal
Severity: normal Version:
Component: Posts, Post Types Keywords: has-patch
Focuses: Cc:

Description

It appears the wp_block post type misses the view_items (plural) label.

That's used in the Editor when editing a reusable block, see https://github.com/WordPress/gutenberg/blob/e8ec1cecf65b8a2e91d727c0fc6947289d1d7706/packages/edit-post/src/components/header/fullscreen-mode-close/index.js#L101

To reproduce:

  • Make sure you have at least one saved reusable block.
  • Access the reusable blocks list page:
    • either edit a regular post > open the main inserter > select the reusable block tab > click 'Manage Reusable blocks'
    • or directly access the page at /wp-admin/edit.php?post_type=wp_block
  • Observe the page title is 'Reusable blocks'.
  • Edit a reusable block.
  • Hover the site icon link at the top left.
  • Observe the tooltip text is 'View Posts' (see screenshot)
  • Expected: 'View Reusable blocks'
  • Given the tooltip text says 'View Posts', I'd expect the link points to the standard posts list page.
  • Click the link: it points to the Reusable blocks page, which is OK but the tooltip text is misleading.

Worth noting other post types miss the view_items (plural) label e.g. wp_template, wp_template_part, wp_navigation, etc. but I'm not sure there's the need for it.

Attachments (2)

view items missiing.png (201.6 KB) - added by afercia 12 months ago.
58209.diff (667 bytes) - added by afercia 12 months ago.

Download all attachments as: .zip

Change History (5)

@afercia
12 months ago

#1 @afercia
12 months ago

  • Keywords has-patch added

#2 @SergeyBiryukov
12 months ago

  • Milestone changed from Awaiting Review to 6.3

#3 @afercia
12 months ago

  • Owner set to afercia
  • Resolution set to fixed
  • Status changed from new to closed

In 55709:

Post Types: Add the view_items label to the wp_block post type.

The view_items post type label is used in the Editor, for the aria-label of the link to go back to the Posts list. When editing a Reusable block, it fallbacks to 'View Posts'. It should be 'View Reusable blocks'.

Fixes #58209.

Note: See TracTickets for help on using tickets.