update_core() does not define $required_php_version and $required_mysql_version global variables

[upadalavipul]

I have reviewed the /wp-admin/includes/update-core.php file and found the update_core function used $required_php_version and $required_mysql_version global variables but does not define it in the function.

File Path: trunk/wp-admin/includes/update-core.ph
Function Name: update_core

[mukesh27]

Hi there! thanks for ticket and patch!

As per ​https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-admin/includes/update-core.php#L1109-L1115 we don't need to add those global variables.

	/*
	 * Import $wp_version, $required_php_version, and $required_mysql_version from the new version.
	 * DO NOT globalize any variables imported from `version-current.php` in this function.
	 *
	 * BC Note: $wp_filesystem->wp_content_dir() returned unslashed pre-2.8.
	 */
	$versions_file = trailingslashit( $wp_filesystem->wp_content_dir() ) . 'upgrade/version-current.php';

[SergeyBiryukov]

Hi there, thanks for the ticket!

As noted above, these variables are intentionally imported with a local scope, see [39687] as a follow-up to [31124].