Make WordPress Core

Opened 12 months ago

Closed 12 months ago

Last modified 10 months ago

#58224 closed task (blessed) (fixed)

Update Sodium Compat to 1.20.0

Reported by: jrf's profile jrf Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 6.3 Priority: normal
Severity: normal Version: 6.3
Component: External Libraries Keywords: has-patch commit add-to-field-guide
Focuses: Cc:

Description

Sodium_Compat 1.20.0 has just been released and fixes a pertinent, though rare bug.

The version included with WP should be updated.

Full details:

I've reviewed the diff and would recommend an update at the earliest convenience.

Previously: #48371, #51399, #51925, #53274, #53907, #55453, #56564, #56642, #56653

Change History (8)

#1 @paragoninitiativeenterprises
12 months ago

Feel free to exclude the wycheproof test commits when deriving the patch from our release diff. (I made them separate commits so they can more easily be skipped.)

#2 @jrf
12 months ago

Thanks for the heads-up @paragoninitiativeenterprises ! If I remember correctly, we don't actually include the tests in the patches which go into WP Core, just the src files.

This ticket was mentioned in PR #4400 on WordPress/wordpress-develop by @costdev.


12 months ago
#3

  • Keywords has-patch added; needs-patch removed

The latest version of sodium_compat includes a fix for the Poly1305 implementation.

Release Notes:
https://github.com/paragonie/sodium_compat/releases/tag/v1.20.0

A full list of changes in this update can be found on GitHub:
https://github.com/paragonie/sodium_compat/compare/v1.19.0...v1.20.0

Trac ticket: https://core.trac.wordpress.org/ticket/58224

#4 @costdev
12 months ago

PR 4400 updates sodium_compat to 1.20.0.

#5 @jrf
12 months ago

  • Keywords commit added

Thanks @costdev for creating a patch. The patch on GitHub has been reviewed and approved (x3).

#6 @SergeyBiryukov
12 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 55699:

Upgrade/Install: Update sodium_compat to v1.20.0.

The latest version of sodium_compat includes a fix for the Poly1305 implementation.

References:

Follow-up to [49741], [51002], [51591], [52988], [54150], [54310].

Props jrf, costdev, paragoninitiativeenterprises, mukesh27.
Fixes #58224.

@SergeyBiryukov commented on PR #4400:


12 months ago
#7

Thanks for the PR! Merged in r55699.

#8 @stevenlinx
10 months ago

  • Keywords add-to-field-guide added
Note: See TracTickets for help on using tickets.