Make WordPress Core

Opened 5 weeks ago

Last modified 21 hours ago

#58225 new defect (bug)

Twenty Sixteen: Deprecated jQuery.fn.unbind

Reported by: malae's profile Malae Owned by:
Milestone: 6.3 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: needs-testing has-patch
Focuses: javascript Cc:

Description

I posted this 2 years ago, but it has not been fixed in Theme: Twenty Sixteen
jQuery.fn.unbind() is deprecated in /twentysixteen/js/functions.js Line 97
siteNavigation.find( '.menu-item-has-children > a' ).unbind( 'touchstart.twentysixteen' );
should be changed to:
siteNavigation.find( '.menu-item-has-children > a' ).on("unbind", 'touchstart.twentysixteen' );

Change History (5)

#1 @audrasjb
5 weeks ago

  • Component changed from Themes to Bundled Theme
  • Keywords needs-patch needs-testing added
  • Version 6.2 deleted

This ticket was mentioned in PR #4404 on WordPress/wordpress-develop by @dilipbheda.


5 weeks ago
#2

  • Keywords has-patch added; needs-patch removed

#3 @dilipbheda
5 weeks ago

@Malae I think jQuery Off method will handle to remove the event I think the jQuery Off method will help to remove the registered event instead of on("unbind", 'touchstart.twentysixteen' );

cc @audrasjb

Thanks

#4 @sabernhardt
3 weeks ago

  • Summary changed from Deprecated jQuery.fn.unbind to Twenty Sixteen: Deprecated jQuery.fn.unbind

#5 @sabernhardt
21 hours ago

  • Milestone changed from Awaiting Review to 6.3

Also: the .unbind() method is found in Twenty Fourteen's slider.js and Twenty Seventeen's navigation.js.

Note: See TracTickets for help on using tickets.