#58225 closed defect (bug) (fixed)
Twenty Sixteen: Deprecated jQuery.fn.unbind
Reported by: | Malae | Owned by: | audrasjb |
---|---|---|---|
Milestone: | 6.3 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | has-patch commit |
Focuses: | javascript | Cc: |
Description
I posted this 2 years ago, but it has not been fixed in Theme: Twenty Sixteen
jQuery.fn.unbind() is deprecated in /twentysixteen/js/functions.js Line 97
siteNavigation.find( '.menu-item-has-children > a' ).unbind( 'touchstart.twentysixteen' );
should be changed to:
siteNavigation.find( '.menu-item-has-children > a' ).on("unbind", 'touchstart.twentysixteen' );
Change History (9)
#1
@
19 months ago
- Component changed from Themes to Bundled Theme
- Keywords needs-patch needs-testing added
- Version 6.2 deleted
This ticket was mentioned in PR #4404 on WordPress/wordpress-develop by @dilipbheda.
19 months ago
#2
- Keywords has-patch added; needs-patch removed
#3
@
19 months ago
@Malae I think jQuery Off method will handle to remove the event I think the jQuery Off method will help to remove the registered event instead of on("unbind", 'touchstart.twentysixteen' );
cc @audrasjb
Thanks
#4
@
19 months ago
- Summary changed from Deprecated jQuery.fn.unbind to Twenty Sixteen: Deprecated jQuery.fn.unbind
#5
@
18 months ago
- Milestone changed from Awaiting Review to 6.3
Also: the .unbind()
method is found in Twenty Fourteen's slider.js
and Twenty Seventeen's navigation.js
.
#6
@
17 months ago
- Keywords commit added; needs-testing removed
- Owner set to audrasjb
- Status changed from new to accepted
Works fine in my testing. Marking for commit.
@dilipbheda @sabernhardt feel free to open other tickets to handle this for T14 and T17 :)
@audrasjb commented on PR #4404:
17 months ago
#9
committed in https://core.trac.wordpress.org/changeset/56102
Trac ticket: https://core.trac.wordpress.org/ticket/58225