Make WordPress Core

Opened 10 months ago

Closed 10 months ago

Last modified 10 months ago

#58244 closed defect (bug) (fixed)

6.3-alpha-55703 style sheet problem?

Reported by: digtek's profile DigTek Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 6.3 Priority: normal
Severity: normal Version: 6.3
Component: General Keywords:
Focuses: Cc:

Description

Had to go back to v6.2 due to css issue in dashboard.

Attachments (1)

Screenshot 2023-05-03 105211.png (157.1 KB) - added by DigTek 10 months ago.
screen of admin dashboard - reverting to 6.2 corrects

Download all attachments as: .zip

Change History (5)

@DigTek
10 months ago

screen of admin dashboard - reverting to 6.2 corrects

#1 @SergeyBiryukov
10 months ago

  • Milestone changed from Awaiting Review to 6.3

Hi there, welcome to WordPress Trac! Thanks for the report.

There is some more context on this in comment:25:ticket:58012.

#2 @SergeyBiryukov
10 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 55710:

General: Restore strpos() check in wp-admin/load-styles.php.

This resolves a fatal error on PHP < 8.0, as wp-includes/compat.php is not loaded in this file, so str_starts_with() may not be available.

Follow-up to [55703].

Props dd32, flixos90, DigTek.
Fixes #58244. See #58012.

#3 follow-up: @samiamnot
10 months ago

@SergeyBiryukov , how do we flag this change for removal once PHP 8.0 is the minimum supported PHP version?

#4 in reply to: ↑ 3 @SergeyBiryukov
10 months ago

Replying to samiamnot:

how do we flag this change for removal once PHP 8.0 is the minimum supported PHP version?

There is some further discussion on this change in comment:32:ticket:58012, perhaps the correct solution would be to load wp-includes/compat.php in wp-admin/load-styles.php instead.

Once PHP 8.0 is the minimum required version, I think there would be an audit for things like this, where we can identify and remove polyfills or workarounds that are no longer relevant, see #47698 or #47699 for example.

Last edited 10 months ago by SergeyBiryukov (previous) (diff)
Note: See TracTickets for help on using tickets.