Make WordPress Core

Opened 13 months ago

Closed 13 months ago

Last modified 13 months ago

#58256 closed defect (bug) (fixed)

HTML API: Restore mistakenly-removed content in documentation.

Reported by: dmsnell's profile dmsnell Owned by: audrasjb's profile audrasjb
Milestone: 6.3 Priority: normal
Severity: normal Version: 6.3
Component: HTML API Keywords: has-patch commit
Focuses: docs Cc:

Description

In a3ed152 the Unicode replacement character was mistakenly removed, being believed to be a text rendering mistake, because the character is the replacement character used in situations where those text mistakes occur.

However, the purpose of including the character was to communicate what it looks like and why the Tag Processor won't insert it into the document (which would be wrong from the Unicode point of view for such a streaming processor that doesn't produce the final rendered view of the text).

In this patch we're bringing back the character and adding a small clue to try and remove the confusion that previously led to its unwanted removal.

Change History (5)

This ticket was mentioned in PR #4426 on WordPress/wordpress-develop by @dmsnell.


13 months ago
#1

Trac: #58256-ticket

In a3ed152c54c117d39d32a72a3d22f082dd5ffa7f the Unicode replacement character was mistakenly removed, being believed to be a text rendering mistake, because the character _is_ the replacement character used in situations where those text mistakes occur.

However, the purpose of including the character was to communicate what it looks like and why the Tag Processor won't insert it into the document (which would be wrong from the Unicode point of view for such a streaming processor that doesn't produce the final rendered view of the text).

In this patch we're bringing back the character and adding a small clue to try and remove the confusion that previously led to its unwanted removal.

#2 @dmsnell
13 months ago

cc: @johnbillion @zieladam

#3 @audrasjb
13 months ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 6.3
  • Version changed from 6.2 to trunk

Thanks for the ticket and patch. Looks good to me.

Introduced in [55718]/#57840 (milestone 6.3, so version is trunk).

#4 @audrasjb
13 months ago

  • Owner set to audrasjb
  • Resolution set to fixed
  • Status changed from new to closed

In 55723:

HTML API: Restore mistakenly-removed content in documentation.

In [55718] the Unicode replacement character was mistakenly removed. The purpose of including the character was to communicate what it looks like and why the Tag Processor won't insert it into the document.

This changeset brings the character back and adds a small clue to fix the confusion that may lead to its removal.

Follow-up to [55718].

Props dmsnell.
Fixes #58256
See #57840.

Note: See TracTickets for help on using tickets.