Make WordPress Core

Opened 14 months ago

Closed 14 months ago

Last modified 14 months ago

#58282 closed enhancement (fixed)

Change wording where `roll back` is used

Reported by: kebbet's profile kebbet Owned by: audrasjb's profile audrasjb
Milestone: 6.3 Priority: normal
Severity: normal Version: 6.3
Component: I18N Keywords: has-patch commit
Focuses: ui-copy Cc:

Description

The terms roll back and rolled back are used in user facing strings, which to a novice user is not that clear, and querky to translate for at least me as a translator.

I suggest using restore and restored in their places.

https://github.com/WordPress/wordpress-develop/pull/4436

Change History (19)

This ticket was mentioned in PR #4436 on WordPress/wordpress-develop by @kebbet.


14 months ago
#1

  • Keywords has-patch added

@kebbet commented on PR #4436:


14 months ago
#2

Thanks for the review @costdev, much better with your suggestions! They are now applied.

#3 @costdev
14 months ago

Thanks for opening this ticket @kebbet!

Following my review on the PR, I thought it was probably a good idea that I dropped a comment on the ticket for posterity 😆

I agree that "Rolled back", "rollback" and "rolling back" and, to an extent, "revert", isn't very accessible language to most non-technical users.

"Restore", "Return to", "Reinstall", "Reverse", "Undo", and such, are much more common words to describe the same process.

It's likely that the appropriate language is contextual rather than a one-size-fits-all solution.

#4 @kebbet
14 months ago

  • Keywords 2nd-opinion removed

Of course, language and the meaning of our words is contextual! My first run was just a suggestion for something else. And beeing a non native speaker of English they revealed my limitations :)

#5 @kebbet
14 months ago

For the record, this PR might need an update after a decision is made in this ticket.

https://github.com/WordPress/wordpress-develop/pull/3958

#6 @NekoJonez
14 months ago

"Returned" or "not changed" or something among those lines I'd use.

This ticket was mentioned in Slack in #core-upgrade-install by pbiron. View the logs.


14 months ago

This ticket was mentioned in Slack in #core by kebbet. View the logs.


14 months ago

#9 @audrasjb
14 months ago

  • Milestone changed from Awaiting Review to 6.3

@SergeyBiryukov commented on PR #4436:


14 months ago
#10

The suggested strings indeed look better to me. Thanks!

#11 @davidbaumwald
14 months ago

+1 to changing the wording. I prefer something like "restore" which a lot of users are familiar with these days in the context of something related to backups. Also, "roll back" might have some ambiguity after being translated.

#12 @audrasjb
14 months ago

  • Owner set to audrasjb
  • Status changed from new to accepted
  • Version set to trunk

With several ✅ reviews, I think we can consider this changeset as ready to ship :)

Self assigning for commit.

#13 @audrasjb
14 months ago

  • Keywords commit added

#14 follow-up: @audrasjb
14 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 55750:

I18N: Replace "Roll back" with "Restore" in user facing strings.

The terms "roll back" and "rolled back" are used in user facing strings since [55720]. These termes are not that clear for novice users and may be difficult to translate in some locales. This changeset replaces "roll back" with "restore" and "rolled back" with "restored" or "not applied" depending of the context of the screen.

Follow-up to [55720].

Props kebbet, costdev, NekoJonez, audrasjb, SergeyBiryukov, davidbaumwald.
Fixes #58282.

#16 @audrasjb
14 months ago

In 55751:

Coding Standards: Use esc_url() to escape link URL value in wp-admin/edit-link-form.php.

Props dilipbheda, mukesh27.
Fixes #58282.
See #57839.

#17 @audrasjb
14 months ago

Sorry for the unrelated commit. [55751] fixes #58268.

Last edited 14 months ago by audrasjb (previous) (diff)

#18 in reply to: ↑ 14 @SergeyBiryukov
14 months ago

Thanks for the commit!

Replying to audrasjb:

The terms "roll back" and "rolled back" are used in user facing strings since [55720].

Just to clarify, these strings were not added in that commit, it does not mention "rollback" in any user-facing strings :)

  • The strings from Core_Upgrader were added in [25649] and adjusted in [25655].
  • The string from wp_print_file_editor_templates() was added in [41721].
Last edited 14 months ago by SergeyBiryukov (previous) (diff)

#19 @audrasjb
14 months ago

Ah yes, I messed up with the different Rollback updates, thanks for clarifying :)

(and I didn't mention wp_print_file_editor_templates() because it's a side change, but that's right!)

Note: See TracTickets for help on using tickets.