Make WordPress Core

Opened 11 months ago

Closed 11 months ago

Last modified 9 months ago

#58301 closed enhancement (fixed)

Deprecate wp_queue_comments_for_comment_meta_lazyload function

Reported by: spacedmonkey's profile spacedmonkey Owned by: spacedmonkey's profile spacedmonkey
Milestone: 6.3 Priority: normal
Severity: normal Version: 4.5
Component: Comments Keywords: good-first-bug has-patch has-dev-note
Focuses: Cc:

Description

As of [55749] wp_queue_comments_for_comment_meta_lazyload is no longer used in core. This function should be deprecated.

Attachments (3)

58301.diff (26.6 KB) - added by sh4lin 11 months ago.
58301.patch (2.6 KB) - added by sh4lin 11 months ago.
has-patch
58301.2.diff (3.5 KB) - added by sh4lin 11 months ago.

Download all attachments as: .zip

Change History (19)

#1 @costdev
11 months ago

Some notes:

This ticket was mentioned in PR #4489 on WordPress/wordpress-develop by @sh4lin.


11 months ago
#2

  • Keywords has-patch added
  • Added the _deprecate_function() inside the wp_queue_comments_for_comment_meta_lazyload() function. Updated the DocBlock for the same function.
  • Updated the DocBlock of WP_Query::lazyload_term_meta( $check, $term_id ) method.

Trac ticket: https://core.trac.wordpress.org/ticket/58301

#3 @spacedmonkey
11 months ago

  • Keywords commit added
  • Milestone changed from Future Release to 6.3
  • Owner set to spacedmonkey
  • Status changed from new to assigned

@sh4lin
11 months ago

@sh4lin
11 months ago

has-patch

@sh4lin
11 months ago

#4 @spacedmonkey
11 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 55855:

Comments: Deprecate wp_queue_comments_for_comment_meta_lazyload function.

As of [55749] wp_queue_comments_for_comment_meta_lazyload is no longer used in core. This commit, deprecates this function. Update docs and tests accordingly.

Props sh4lin, spacedmonkey, costdev, peterwilsoncc.
Fixes #58301.

#6 @SergeyBiryukov
11 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Curious, why it was added to wp-admin/includes/deprecated.php instead of wp-includes/deprecated.php?

Since the function was previously in wp-includes/comment.php, the latter appears to be the correct place.

#7 @spacedmonkey
11 months ago

@SergeyBiryukov I didn't notice that. I saw the file name and didn't check the path. Give me a minute and I will fix.

#10 @spacedmonkey
11 months ago

In 55856:

Comments: Move wp_queue_comments_for_comment_meta_lazyload function to the correct file.

As of [55855] wp_queue_comments_for_comment_meta_lazyload was deprecated. But deprecate to wp-admin/deprecated.php and not wp-includes/deprecated.php.This is incorrect, as this is a public function and not an admin function.

Props SergeyBiryukov, spacedmonkey.
See #58301.

#11 @spacedmonkey
11 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

@spacedmonkey commented on PR #4508:


11 months ago
#12

Committed.

#13 @flixos90
10 months ago

In 56110:

General: Add missing parentheses to functions referenced in _deprecated_function() calls added in 6.3.

See #58235, #58301, #58555.

#14 @stevenlinx
10 months ago

  • Keywords has-dev-note added

#16 @spacedmonkey
9 months ago

  • Keywords commit removed
Note: See TracTickets for help on using tickets.