#58301 closed enhancement (fixed)
Deprecate wp_queue_comments_for_comment_meta_lazyload function
Reported by: | spacedmonkey | Owned by: | spacedmonkey |
---|---|---|---|
Milestone: | 6.3 | Priority: | normal |
Severity: | normal | Version: | 4.5 |
Component: | Comments | Keywords: | good-first-bug has-patch has-dev-note |
Focuses: | Cc: |
Description
As of [55749] wp_queue_comments_for_comment_meta_lazyload
is no longer used in core. This function should be deprecated.
Attachments (3)
Change History (19)
This ticket was mentioned in PR #4489 on WordPress/wordpress-develop by @sh4lin.
19 months ago
#2
- Keywords has-patch added
- Added the _deprecate_function() inside the wp_queue_comments_for_comment_meta_lazyload() function. Updated the DocBlock for the same function.
- Updated the DocBlock of WP_Query::lazyload_term_meta( $check, $term_id ) method.
Trac ticket: https://core.trac.wordpress.org/ticket/58301
#3
@
19 months ago
- Keywords commit added
- Milestone changed from Future Release to 6.3
- Owner set to spacedmonkey
- Status changed from new to assigned
@spacedmonkey commented on PR #4489:
19 months ago
#5
#6
@
19 months ago
- Resolution fixed deleted
- Status changed from closed to reopened
Curious, why it was added to wp-admin/includes/deprecated.php
instead of wp-includes/deprecated.php
?
Since the function was previously in wp-includes/comment.php
, the latter appears to be the correct place.
#7
@
19 months ago
@SergeyBiryukov I didn't notice that. I saw the file name and didn't check the path. Give me a minute and I will fix.
This ticket was mentioned in PR #4508 on WordPress/wordpress-develop by @spacedmonkey.
19 months ago
#8
Trac ticket: https://core.trac.wordpress.org/ticket/58301
#9
@
19 months ago
@SergeyBiryukov Can you take a look at https://github.com/WordPress/wordpress-develop/pull/4508
@spacedmonkey commented on PR #4508:
19 months ago
#12
Committed.
Some notes:
wp_queue_comments_for_comment_meta_lazyload()
instead. The docblock should be updated to point extenders towp_lazyload_comment_meta()
instead, also introduced in [55749].