Make WordPress Core

Opened 13 months ago

Last modified 13 months ago

#58307 new enhancement

Theme Search Filter Not Working

Reported by: heymehedi's profile heymehedi Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 6.2
Component: Themes Keywords: has-patch
Focuses: ui, administration Cc:

Description

During my search for a block-based marketing theme, I attempted to navigate to the 'Block Themes' tab area and enter relevant keywords such as "Marketing". Unfortunately, I was redirected to the general themes listing tab instead. For further information and context, please refer to this record:
https://drive.google.com/file/d/11t5GKFbig3sy4zSMyUPlyH0FlC_a81pw/view

Change History (7)

#1 @utsavladani
13 months ago

Hello @heymehedi,

I went through this issue and found that this is not a WordPress bug. We can either search by the browse tab like Popular, Latest, Block Themes, and Favorites OR search query. Both don't work together.

But WordPress should have this feature for search themes. So I implemented a solution that will work on both conditions. Here is the demo link: https://drive.google.com/file/d/1TzPSeKu1INgu_lp5f1zpKvJbZsOQPnAY/view?usp=sharing

If this works, then I will create a patch.

#2 @utsavladani
13 months ago

  • Type changed from defect (bug) to enhancement

This ticket was mentioned in PR #4505 on WordPress/wordpress-develop by Utsav-Ladani.


13 months ago
#3

  • Keywords has-patch added

## Enhance Theme Search Functionality

Trac ticket: https://core.trac.wordpress.org/ticket/58307

## Current behavior

  • In the current version, we can only search themes using either the browse tab or search term, but we can't use both together.

## Enhancement

  • This PR enhances the theme functionality by supporting the combined query.
  • User can search the theme using a browse and a search term.
  • We can also apply filters on search from the filter tab.
  • Add a remove filter button after the edit button to remove all filters without opening the filter panel.

#4 @utsavladani
13 months ago

Hey @SergeyBiryukov and @spacedmonkey,

I created a patch for this enhancement and raised a PR. Please, can you look at it?

#5 follow-up: @spacedmonkey
13 months ago

I am not sure I am the best person to look at this PR. It is a sub system I haven't worked with very much and haven't worked with backbone much either.

The maintainer of theme might be better @williampatton @sagarprajapati.

#6 in reply to: ↑ 5 @utsavladani
13 months ago

Replying to spacedmonkey:

I am not sure I am the best person to look at this PR. It is a sub system I haven't worked with very much and haven't worked with backbone much either.

The maintainer of theme might be better @williampatton @sagarprajapati.

Thank you, @spacedmonkey.

#7 @utsavladani
13 months ago

Hello @williampatton and @sagarprajapati,

I created a patch for this enhancement and raised a PR. Please, can you look at it?

Note: See TracTickets for help on using tickets.