Make WordPress Core

Opened 3 years ago

Closed 16 months ago

#58337 closed defect (bug) (wontfix)

Indentation and Spacing Issue in rss.php File

Reported by: madhusudandev Owned by:
Priority: low Milestone:
Component: Feeds Version:
Severity: normal Keywords: has-patch close
Cc: Focuses: coding-standards

Description

I have noticed indentation and spacing issue within the rss.php file in WordPress. The problem lies in inconsistent indentation and spacing throughout the code, which hinders readability and comprehension.

Indentation and spacing issue found in the following lines of code within a wp-includes/rss.php

​https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-includes/rss.php#L77
​https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-includes/rss.php#L109
​https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-includes/rss.php#L125
​https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-includes/rss.php#L146
​https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-includes/rss.php#L176

Change History (6)

This ticket was mentioned in ​PR #4465 on ​WordPress/wordpress-develop by ​madhusudan-hub.


3 years ago
#1

  • Keywords has-patch added

Indentation and Spacing Issue fixed.

Trac ticket: https://core.trac.wordpress.org/ticket/58337

#2 @audrasjb
3 years ago

  • Component General → Feeds

Hello and thanks for the ticket,

Worth noting that MagpieRSS is an external library and its use in WordPress is deprecated since version 3.0, that's why it doesn't respect WordPress Coding Standards :)

#3 @sabernhardt
3 years ago

  • Priority normal → low

Thanks for the report and patch!

See #57107 for future plans with the MagpieRSS file.

A few typographical errors were fixed recently in [55336] and [55644], though editing for coding standards may be too much now. Of course, I will not complain if a committer finds value in changing this, too.

This ticket was mentioned in ​Slack in #core-test by ironprogrammer. ​View the logs.


3 years ago

#5 @ironprogrammer
3 years ago

  • Keywords close added

This ticket was reviewed during test triage.

Because the class in question has been proposed to deprecate in #57107, we've added close to the ticket. Why? Rather than marking for dev-feedback, this will raise the ticket with core committers anyways, who can then evaluate moving it forward or not.

#6 @sabernhardt
16 months ago

  • Milestone Awaiting Review
  • Resolution → wontfix
  • Status new → closed

A ​committers meeting identified the desire to no-op or remove old deprecated classes as a short-term task. #57107 would be the direction to take now.

Note: See TracTickets for help on using tickets.