WordPress.org
Get WordPress

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#58338 closed defect (bug) (fixed)

Found a grammatical mistake in the option.php file

Reported by: nazmulhudadev's profile nazmulhudadev Owned by: audrasjb's profile audrasjb
Milestone: 6.3 Priority: low
Severity: normal Version:
Component: Options, Meta APIs Keywords: has-patch commit
Focuses: coding-standards Cc:

Description

Hi, I found a grammatical mistake in the option.php file. It's a minor issue, but I think it should be fixed.

The mistake was found in the following line:

​https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-includes/option.php#L1373

Change History (17)

This ticket was mentioned in ​PR #4466 on ​WordPress/wordpress-develop by ​@nazmulhudadev.
2 years ago #1

  • Keywords has-patch added

The mistake has been fixed.

Trac ticket: https://core.trac.wordpress.org/ticket/58338

#2 @audrasjb
2 years ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 6.3
  • Owner set to audrasjb
  • Status changed from new to accepted

Thanks for spotting this small typo. Self assigning for quick commit alongside other DocBlocks issues.

Last edited 2 years ago by audrasjb (previous) (diff)

#3 @audrasjb
2 years ago

This changeset can be committed with #58340.

​@nazmulhudadev commented on ​PR #4466:
2 years ago #4

Hi @mukeshpanchal27,

Thanks for reviewing the changes.

I've made the required changes in ​line 730 as well.

​@nazmulhudadev commented on ​PR #4466:
2 years ago #7

Hi @krupal-panchal,

Thanks for spotting the typo.
It has been fixed in a new PR ​https://github.com/WordPress/wordpress-develop/pull/4480

#8 @krupalpanchal
2 years ago

Both PR Looks good to me. Approved!

#9 @mukesh27
2 years ago

  • Keywords changes-requested added
  • Priority changed from normal to low

@nazmulhudadev Instead of multiple PR can you make single PR so it's easy to review and commit
?

​@mukesh27 commented on ​PR #4466:
2 years ago #10

Merge the changes in ​https://github.com/WordPress/wordpress-develop/pull/4480 into this and close that PR.

​@nazmulhudadev commented on ​PR #4480:
2 years ago #11

The changes of this PR have been merged with ​https://github.com/WordPress/wordpress-develop/pull/4466

#12 @nazmulhudadev
2 years ago

Hi @mukesh27,

Thanks for the suggestion. I appreciate your effort to make it easier and better.

The changes in ​PR #4480 have been merged into ​PR #4466 by a new ​commit.

Also, ​PR #4480 has been closed.

#13 @mukesh27
2 years ago

  • Keywords changes-requested removed

Awesome, Thanks @nazmulhudadev.

#14 @SergeyBiryukov
2 years ago

Thanks for the PR! The typo appears to be fixed in [55827] / #57840, sorry I didn't notice that one of the fixes in that commit was first suggested here.

We should still include the other two DocBlock edits from the PR, as they improve readability and consistency.

This ticket was mentioned in ​Slack in #core by chaion07. ​View the logs.
2 years ago

#16 @audrasjb
2 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 55884:

Docs: Fix a few more typos in Docblocks.

Follow-up to [6779], [10565], [12023], [25224], [27533], [32806], [34777], [45262], [46594], [55823], [55824], [55827].

Props nazmulhudadev, mukesh27.
Fixes #58338.
See #57840.

Note: See TracTickets for help on using tickets.