Make WordPress Core

Opened 11 months ago

Closed 11 months ago

Last modified 11 months ago

#58373 closed defect (bug) (fixed)

Link to return to updates page after core update is too long

Reported by: nekojonez's profile NekoJonez Owned by: audrasjb's profile audrasjb
Milestone: 6.3 Priority: normal
Severity: normal Version:
Component: Help/About Keywords: good-first-bug has-patch commit
Focuses: ui, css, administration Cc:

Description

When you do a core update, an additional link is added at the bottom of the about.php page. "Go to Dashboard → Updates" ... Yet, the underline of the link includes the white space after that while it shouldn't. Since, that isn't the text anymore.

See screenshots.

Attachments (2)

A.png (63.5 KB) - added by NekoJonez 11 months ago.
B.png (2.9 KB) - added by NekoJonez 11 months ago.

Download all attachments as: .zip

Change History (16)

@NekoJonez
11 months ago

@NekoJonez
11 months ago

#1 @audrasjb
11 months ago

  • Keywords good-first-bug added
  • Milestone changed from Awaiting Review to 6.3
  • Owner set to audrasjb
  • Status changed from new to accepted

Good catch :)

Note: to reproduce the issue, update (or reinstall) WordPress on a multisite. You'll be redirected to the about page with the updated parameter.

Adding good-first-bug to encourage people who never contributed to WordPress Core to send a patch for this small issue :)

This ticket was mentioned in PR #4484 on WordPress/wordpress-develop by ahsannayem.


11 months ago
#2

  • Keywords has-patch added

#3 @mukesh27
11 months ago

  • Keywords needs-refresh added

Hi there!

More information for new contributor. Open https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-admin/about.php and change code in single line and share the Patch/PR.

<a href="<?php echo esc_url( self_admin_url( 'update-core.php' ) ); ?>">
	<?php is_multisite() ? _e( 'Go to Updates' ) : _e( 'Go to Dashboard &rarr; Updates' ); ?>
</a> |

Replace to

<a href="<?php echo esc_url( self_admin_url( 'update-core.php' ) ); ?>"><?php is_multisite() ? _e( 'Go to Updates' ) : _e( 'Go to Dashboard &rarr; Updates' ); ?></a> |

This ticket was mentioned in PR #4485 on WordPress/wordpress-develop by @sumitbagthariya16.


11 months ago
#4

  • Keywords needs-refresh removed

#6 follow-up: @audrasjb
11 months ago

Thanks for the patch @sumitbagthariya16, however I'm wondering what part of this sentence was not clear to you 😒

Adding good-first-bug to encourage people who never contributed to WordPress Core to send a patch for this small issue

People who already contributed to WordPress Core must leave good-first-bug to very new contributors, as it is a great way to learn how to contribute.

@audrasjb commented on PR #4484:


11 months ago
#7

Thanks for the PR @ahsannayem!
Looks almost good to go. We just need to fix a small coding standards issue (see Mukesh's comment above).
Can you please update your PR accordingly?

Also, can you please link your GitHub account on your WordPress.org profile? (just go to your WordPress.org profile and use the GitHub field)

Thanks!

#8 in reply to: ↑ 6 @sumitbagthariya16
11 months ago

@audrasjb thanks for the update however this is my first commit in the code (I am a QA engineer) and I have never contributed in the code, so I considered it the best start as a good first bug PR.

Replying to audrasjb:

Thanks for the patch @sumitbagthariya16, however I'm wondering what part of this sentence was not clear to you 😒

Adding good-first-bug to encourage people who never contributed to WordPress Core to send a patch for this small issue

People who already contributed to WordPress Core must leave good-first-bug to very new contributors, as it is a great way to learn how to contribute.

#9 @audrasjb
11 months ago

I saw the Core badge and various props from several tickets on your profile, and wanted to make it clear that good first bug are generally small bugs with low priority kept for educational purpose.
But if it's your very first patch, I think we can indeed say that is applies to the good-first-bug spirit. Thanks for clarifying!

#10 @ahsannayem
11 months ago

Hello @audrasjb

This is my first ever try. And many thanks for your comment, I will link the github account.

Thank you

#11 @audrasjb
11 months ago

  • Component changed from Administration to Help/About
  • Keywords commit added

#12 @audrasjb
11 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 55848:

Help/About: Remove unwanted space in a link located on about.php.

This fixes a small interface glitch in the Go to Updates link located on
the the About screen.

Props NekoJonez, mukesh27, sumitbagthariya16, ahsannayem.
Fixes #58373.

Note: See TracTickets for help on using tickets.