Link to return to updates page after core update is too long

[NekoJonez]

When you do a core update, an additional link is added at the bottom of the about.php page. "Go to Dashboard → Updates" ... Yet, the underline of the link includes the white space after that while it shouldn't. Since, that isn't the text anymore.

See screenshots.

[audrasjb]

Good catch :)

Note: to reproduce the issue, update (or reinstall) WordPress on a multisite. You'll be redirected to the about page with the updated parameter.

Adding good-first-bug to encourage people who never contributed to WordPress Core to send a patch for this small issue :)

Trac ticket: https://core.trac.wordpress.org/ticket/58373

[mukesh27]

Hi there!

More information for new contributor. Open ​https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-admin/about.php and change code in single line and share the Patch/PR.

<a href="<?php echo esc_url( self_admin_url( 'update-core.php' ) ); ?>">
	<?php is_multisite() ? _e( 'Go to Updates' ) : _e( 'Go to Dashboard &rarr; Updates' ); ?>
</a> |

Replace to

<a href="<?php echo esc_url( self_admin_url( 'update-core.php' ) ); ?>"><?php is_multisite() ? _e( 'Go to Updates' ) : _e( 'Go to Dashboard &rarr; Updates' ); ?></a> |

Trac ticket: https://core.trac.wordpress.org/ticket/58373

[sumitbagthariya16]

@mukesh27 I have raised a PR at ​https://github.com/WordPress/wordpress-develop/pull/4485

[audrasjb]

Thanks for the patch @sumitbagthariya16, however I'm wondering what part of this sentence was not clear to you 😒

Adding good-first-bug to encourage people who never contributed to WordPress Core to send a patch for this small issue

People who already contributed to WordPress Core must leave good-first-bug to very new contributors, as it is a great way to learn how to contribute.

Thanks for the PR @ahsannayem!
Looks almost good to go. We just need to fix a small coding standards issue (see Mukesh's comment above).
Can you please update your PR accordingly?

Also, can you please link your GitHub account on your WordPress.org profile? (just go to your WordPress.org profile and use the GitHub field)

Thanks!

[sumitbagthariya16]

@audrasjb thanks for the update however this is my first commit in the code (I am a QA engineer) and I have never contributed in the code, so I considered it the best start as a good first bug PR.

Replying to audrasjb:

Thanks for the patch @sumitbagthariya16, however I'm wondering what part of this sentence was not clear to you 😒

Adding good-first-bug to encourage people who never contributed to WordPress Core to send a patch for this small issue

People who already contributed to WordPress Core must leave good-first-bug to very new contributors, as it is a great way to learn how to contribute.

[audrasjb]

I saw the Core badge and various props from several tickets on your profile, and wanted to make it clear that good first bug are generally small bugs with low priority kept for educational purpose.
But if it's your very first patch, I think we can indeed say that is applies to the good-first-bug spirit. Thanks for clarifying!

[ahsannayem]

Hello @audrasjb

This is my first ever try. And many thanks for your comment, I will link the github account.

Thank you

[audrasjb]

In 55848:

Help/About: Remove unwanted space in a link located on about.php.

This fixes a small interface glitch in the Go to Updates link located on
the the About screen.

Props NekoJonez, mukesh27, sumitbagthariya16, ahsannayem.
Fixes #58373.

Committed in https://core.trac.wordpress.org/changeset/55848

committed in https://core.trac.wordpress.org/changeset/55848