Use esc_attr() in _navigation_markup()

[sabernhardt]

Follow-up to #47123 / [46236]

The esc_attr escaping function should be more appropriate for the aria-label attribute than esc_html.
source:/tags/6.2/src/wp-includes/link-template.php#L3024​

[costdev]

Makes sense and the patch looks straightforward.

@sabernhardt does the whole unit test suite still pass locally? Just in case this causes an unexpected failure somewhere along the line.

[SergeyBiryukov]

Good catch, thanks!

[sabernhardt]

I could make a PR to check the unit tests.

Trac ticket: https://core.trac.wordpress.org/ticket/58387

[sabernhardt]

The unit tests passed.

[costdev]

Nice, thanks for that @sabernhardt, seems like a clean and simple change!

@sabernhardt one question: $aria_label is use value of $screen_reader_text so do we need to update $screen_reader_text also?

The standard template uses the $screen_reader_text variable inside an h2 element.

(Without an $aria_label argument, the function would reuse $screen_reader_text for both the aria-label attribute and the heading. They still would have different escaping functions.)

Make sense, thanks @sabernhardt for clarification.

[SergeyBiryukov]

In 55863:

Themes: Use correct escaping function for aria-label in _navigation_markup().

Follow-up to [46236].

Props sabernhardt, costdev, mukesh27.
Fixes #58387.

Thanks for the PR! Merged in r55863.