Add $post parameter to the wp_trash_post action.

[mujuonly]

The $post variable is already available in the wp_trash_post() function so it can just be passed.

Should be the same for the below functions as well to maintain the consistency

trashed_post
untrash_post
untrashed_post

Add $post parameter to wp_trash_post action

Trac ticket: https://core.trac.wordpress.org/ticket/58392

[mukesh27]

Hi there! thanks for the ticket and PR.

Left one minor feedback.

[nihar007]

Hi,
I checked the source code and I saw trashed_post, untrash_post, untrashed_post methods require post id not post and used multiple places. I think post id is the best.

[dhruvishah2203]

diff file uploaded

[SergeyBiryukov]

Hi there, thanks for the ticket!

Taking a closer look here:

• pre_trash_post receives $post.
• wp_trash_post receives $post_id.
• trashed_post receives $post_id.
• pre_untrash_post receives $post and $previous_status.
• untrash_post receives $post_id and $previous_status.
• untrashed_post receives $post_id and $previous_status.

See [49125] / #23022 for reference.

It appears that passing $previous_status to the former three hooks would bring more consistency, so 58392.2.diff​ does just that.

Would that be enough here, or do we still need to pass $post to wp_trash_post and untrash_post? Could you share the use case for that?

[costdev]

This ticket was discussed during the bug scrub. As this is new code and to ensure that the parameters are always passed in future, we agreed that this should have a unit test to verify the expected parameters are received.

Additional props: @mukesh27 @oglekler

Trac ticket: https://core.trac.wordpress.org/ticket/58392

This PR adds unit tests to the previously proposed diff.

[hugod]

Hi,
I added tests in ​https://github.com/WordPress/wordpress-develop/pull/4580.
Tell me if it lacks of anything.

[audrasjb]

Thanks for the unit tests @hugod!
I added some feedback in the PR :)

Hi @audrasjb and @costdev 👋
Thanks for the feedback!
I've split the test and added some docblocks as you suggested.

Thanks for the insight @costdev! Nice to see how standardization is going 🙂

[audrasjb]

Self assigning for final review.

[oglekler]

I am adding needs-testing to highlight that this patch is ready for review.

[audrasjb]

In 56043:

Posts, Post Types: Add a $previous_status parameter to wp_trash_post() related hooks.

This adds a $previous_status parameter to the pre_trash_post, wp_trash_post, and trashed_post hooks.

Props mujuonly, mukesh27, nihar007, dhruvishah2203, SergeyBiryukov, costdev, hugod, audrasjb, oglekler.
Fixes #58392.

committed in https://core.trac.wordpress.org/changeset/56043