WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 2 of Ticket #58405


Ignore:
Timestamp:
05/29/2023 06:49:17 AM (3 years ago)
Author:
mukesh27
Comment:

Hi there!

Thanks for PR/Patch both of you.

@nihar007 in your patch do you use different approach then ​PR 4514? Instead of adding duplicate patch try you can check review the PR and share your feedback on it. Thanks!

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #58405

    • Property Keywords has-patch changes-requested added

  • Ticket #58405 – Description

    initial v2  
    1 In line of 366 / 367 of the `WP_Theme` class, there are manual calls to if files exists. However, in this context we can use the method `is_block_theme`. This remove repeated code and hit an existing cache.
     1Hi there!
     2
     3Thank you both for the PR and patch.
     4
     5@nihar007, in your patch, did you take a different approach than PR 4514 ([https://github.com/WordPress/wordpress-develop/pull/4514])? Instead of adding a duplicate patch, please review the PR and provide your feedback on it. Thank you!