Make WordPress Core

#58409 closed defect (bug) (fixed)

Twenty Sixteen: List block with background color does not have padding in the editor

Reported by: nidhidhandhukiya's profile nidhidhandhukiya Owned by: audrasjb's profile audrasjb
Milestone: 6.3 Priority: normal
Severity: minor Version: 6.2.2
Component: Bundled Theme Keywords: has-patch commit has-screenshots
Focuses: css Cc:

Description

Steps to reproduce the issue :-

  1. Activate Twenty Sixteen Theme.
  2. Choose List block.
  3. Add some text.
  4. Apply background color.

You can able to see the difference between editor side and user side.
I have attached video for better understanding.
Video URL :- https://share.cleanshot.com/Gl7WbjHj6HbLd1Xkw8X8

Attachments (4)

58409.patch (451 bytes) - added by nidhidhandhukiya 11 months ago.
58409.2.patch (514 bytes) - added by sabernhardt 11 months ago.
Capture d’écran 2023-06-21 à 16.55.47.png (36.6 KB) - added by audrasjb 10 months ago.
Before patch
Capture d’écran 2023-06-21 à 17.00.21.png (40.0 KB) - added by audrasjb 10 months ago.
After patch

Download all attachments as: .zip

Change History (11)

#1 @sabernhardt
11 months ago

  • Focuses css added
  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 6.3
  • Summary changed from Twenty Sixteen - List block having design issue in editor side when background is selected. to Twenty Sixteen: List block with background color does not have padding in the editor

The style should not need !important. Adding one more class (.editor-styles-wrapper) seems sufficient.

#2 @pavanpatil1
11 months ago

Test report - https://core.trac.wordpress.org/attachment/ticket/58409/58409.2.patch

Environment:

WordPress- v6.2.2
Os- win10
Browser- Chrome
Theme- Twenty Sixteen

Screenshot:

Before- https://prnt.sc/SqLLtfTV_oBA

After - https://prnt.sc/JRCDlwXRErW_

The patch seems working fine.

#3 @poena
10 months ago

  • Keywords commit added

Test Report

This report validates that the indicated patch addresses the issue.

Patch tested: https://core.trac.wordpress.org/attachment/ticket/58409/58409.2.patch

Environment

  • OS: macOS 13.4
  • Web Server: Nginx
  • PHP: 7.4.30
  • WordPress: 6.3-alpha
  • Browser: Chrome Version 114.0.5735.133
  • Theme: Twenty Sixteen

Actual Results

  • ✅ Issue resolved with patch.

#4 @audrasjb
10 months ago

Thanks for the patch and tests! Self assigning for commit.

#5 @audrasjb
10 months ago

  • Owner set to audrasjb
  • Status changed from new to assigned

#6 @audrasjb
10 months ago

  • Keywords has-screenshots added

@pavanpatil1 I'm not sure you tested the correct thing: your first screenshot shows the front-end which is not concerned by the issue, and the second one is not accessible.

I added two screenshot demonstrating that the patch solves the issue.

#7 @audrasjb
10 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 55966:

Twenty Sixteen: Fix List block padding in the editor.

Props nidhidhandhukiya, sabernhardt, poena.
Fixes #58409.

Note: See TracTickets for help on using tickets.