#58437 closed enhancement (fixed)
Twenty Twenty-Two: Add missing tags
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 6.3 | Priority: | normal |
Severity: | normal | Version: | 6.3 |
Component: | Bundled Theme | Keywords: | has-patch has-testing-info has-screenshots commit |
Focuses: | Cc: |
Description (last modified by )
Some of the subject tags and other features tag were missing. This PR will add those missing tags.
Change History (16)
This ticket was mentioned in PR #4530 on WordPress/wordpress-develop by @kafleg.
21 months ago
#2
- Keywords has-patch added
Add missing tags in TT2 theme
Trac ticket: https://core.trac.wordpress.org/ticket/58437
#3
@
21 months ago
Test Report ✅
Env
- WordPress - 6.3-alpha-20230601.114605
- Chrome Version - 113
- OS - macOS Monterey V12.3.1
- Theme: Twenty Twenty Two
- PHP - 8.0.1
- Web Server - Apache
- Database - MySQL 5.7.28
- Used PR for Testing - https://github.com/WordPress/wordpress-develop/pull/4530
Steps to test
- Goto WP Dashboard > Appearance > Themes
- Search Twenty Twenty-Two theme
- CLick on Theme Details
- Verify the changes
Test result
The changes look good. Tags are updated according to the changes. 🚀
Screenshots:
Before Vs. After
![]() | ![]() |
#6
@
21 months ago
- Summary changed from Add missing tags in Twenty Twenty Two theme to Twenty Twenty-Two: Add missing tags
@SergeyBiryukov commented on PR #4530:
21 months ago
#7
Hi there, thanks for the PR!
It appears that the PR includes some unrelated formatting changes removing the spaces around the >
character. I think it makes those selectors a bit less readable and less consistent with other themes like Twenty Twenty-One, so it's probably out of scope for this PR. Could we just add the missing tags here?
21 months ago
#8
Hi @SergeyBiryukov
That might because of the editor auto-formatting. And yes, we can simply add the tags here.
How can I do that or you'll take care of it?
This ticket was mentioned in PR #4532 on WordPress/wordpress-develop by @Ankit K Gupta.
21 months ago
#9
Added missing tags in Twenty Twenty-Two theme
Trac ticket: https://core.trac.wordpress.org/ticket/58437
@Ankit K Gupta commented on PR #4530:
21 months ago
#10
Hi @SergeyBiryukov That might because of the editor auto-formatting. And yes, we can simply add the tags here. How can I do that or you'll take care of it?
@kafleg
I just created a new PR https://github.com/WordPress/wordpress-develop/pull/4532 in support of your PR. Copied the tags from your PR and added them in style.css.
Please let me know if anything is missing there. Thanks for finding missing tags and creating a ticket.
@mukesh27 commented on PR #4530:
21 months ago
#12
Hi @SergeyBiryukov That might because of the editor auto-formatting. And yes, we can simply add the tags here. How can I do that or you'll take care of it?
Better to update your PR.
#13
@
20 months ago
- Keywords commit added
All comments and requests for changes on the PR have been adressed.
The change looks good to me.
#14
@
20 months ago
- Owner set to SergeyBiryukov
- Resolution set to fixed
- Status changed from new to closed
In 55965:
@SergeyBiryukov commented on PR #4530:
20 months ago
#15
Thanks for the PR! Merged in r55965.
@SergeyBiryukov commented on PR #4532:
20 months ago
#16
Thanks for the PR! Merged in r55965.
Hi @kafleg, Thanks for ticket.
Can you please open PR agains wordpress-develop branch instead of fork repo?