Make WordPress Core

Opened 11 months ago

Closed 10 months ago

Last modified 10 months ago

#58437 closed enhancement (fixed)

Twenty Twenty-Two: Add missing tags

Reported by: kafleg's profile kafleg Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 6.3 Priority: normal
Severity: normal Version: 6.3
Component: Bundled Theme Keywords: has-patch has-testing-info has-screenshots commit
Focuses: Cc:

Description (last modified by mukesh27)

Some of the subject tags and other features tag were missing. This PR will add those missing tags.

Change History (16)

#1 @mukesh27
11 months ago

Hi @kafleg, Thanks for ticket.

Can you please open PR agains wordpress-develop branch instead of fork repo?

This ticket was mentioned in PR #4530 on WordPress/wordpress-develop by @kafleg.


11 months ago
#2

  • Keywords has-patch added

Add missing tags in TT2 theme

Trac ticket: https://core.trac.wordpress.org/ticket/58437

#3 @Ankit K Gupta
11 months ago

Test Report ✅

Env

Steps to test

  1. Goto WP Dashboard > Appearance > Themes
  2. Search Twenty Twenty-Two theme
  3. CLick on Theme Details
  4. Verify the changes

Test result

The changes look good. Tags are updated according to the changes. 🚀

Screenshots:

Before Vs. After

https://i.imgur.com/fp3ov2x.jpg https://i.imgur.com/VJFR2SQ.jpg

#4 @Ankit K Gupta
11 months ago

  • Keywords has-testing-info has-screenshots added

#5 @mukesh27
11 months ago

  • Description modified (diff)
  • Milestone changed from Awaiting Review to 6.3

#6 @SergeyBiryukov
11 months ago

  • Summary changed from Add missing tags in Twenty Twenty Two theme to Twenty Twenty-Two: Add missing tags

@SergeyBiryukov commented on PR #4530:


11 months ago
#7

Hi there, thanks for the PR!

It appears that the PR includes some unrelated formatting changes removing the spaces around the > character. I think it makes those selectors a bit less readable and less consistent with other themes like Twenty Twenty-One, so it's probably out of scope for this PR. Could we just add the missing tags here?

@kafleg commented on PR #4530:


11 months ago
#8

Hi @SergeyBiryukov
That might because of the editor auto-formatting. And yes, we can simply add the tags here.
How can I do that or you'll take care of it?

This ticket was mentioned in PR #4532 on WordPress/wordpress-develop by @Ankit K Gupta.


11 months ago
#9

Added missing tags in Twenty Twenty-Two theme

Trac ticket: https://core.trac.wordpress.org/ticket/58437

@Ankit K Gupta commented on PR #4530:


11 months ago
#10

Hi @SergeyBiryukov That might because of the editor auto-formatting. And yes, we can simply add the tags here. How can I do that or you'll take care of it?

@kafleg
I just created a new PR https://github.com/WordPress/wordpress-develop/pull/4532 in support of your PR. Copied the tags from your PR and added them in style.css.
Please let me know if anything is missing there. Thanks for finding missing tags and creating a ticket.

@kafleg commented on PR #4530:


11 months ago
#11

Looks good to me.

Thank you

@mukesh27 commented on PR #4530:


10 months ago
#12

Hi @SergeyBiryukov That might because of the editor auto-formatting. And yes, we can simply add the tags here. How can I do that or you'll take care of it?

Better to update your PR.

#13 @poena
10 months ago

  • Keywords commit added

All comments and requests for changes on the PR have been adressed.
The change looks good to me.

#14 @SergeyBiryukov
10 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 55965:

Twenty Twenty-Two: Add missing subject tags and feature tags.

Follow-up to [52081], [54168].

Props kafleg, mukesh27, ankit-k-gupta, poena, SergeyBiryukov.
Fixes #58437.

@SergeyBiryukov commented on PR #4530:


10 months ago
#15

Thanks for the PR! Merged in r55965.

@SergeyBiryukov commented on PR #4532:


10 months ago
#16

Thanks for the PR! Merged in r55965.

Note: See TracTickets for help on using tickets.