#58440 closed defect (bug) (fixed)
Twenty Nineteen: Inconsistent H1 font size
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 6.6 | Priority: | normal |
Severity: | minor | Version: | 5.0 |
Component: | Bundled Theme | Keywords: | has-screenshots has-patch needs-testing |
Focuses: | css | Cc: |
Description
The H1 or .entry-title for pages is not the same between the editor and the front end for the Twenty Nineteen theme. The .entry-title class in the style.css overwriting it to be 2.25em large.
Steps to reproduce the issue:
- Activate Twenty Nineteen theme.
- Edit a page
- Inspect or notice page title font size in the editor (H1)
- Save and view front end of page and inspect/notice difference in font size of page title
Attachments (6)
Change History (16)
#1
@
21 months ago
- Summary changed from Twenty Nineteen - Inconsistent H1 font size to Twenty Nineteen: Inconsistent H1 font size
- Version changed from 6.2.2 to 5.0
Headings with the entry-title
class have always been smaller than the h1
element's size. I do not recommend increasing the size on the front end unexpectedly after more than four years, even if that is an improvement.
Matching the editor to the front might be as simple as adding .wp-block-post-title
with the h2
editor styles:
.wp-block-post-title, h2 { font-size: $font__size-lg; @include post-section-dash; @include media(tablet) { font-size: $font__size-xl; } }
(Note: The .wp-block-post-title
class would not work in older versions of WordPress, such as 5.0 and 5.3.)
#2
@
10 months ago
- Keywords changes-requested added
I think it makes sense to ensure that the front looks like the editor where possible. I agree with you, @sabernhardt, that increasing the size doesn't feel the right path here. If a more passive patch, as you recommend, could be produced, I would like to explore that. Thank you, everyone.
This ticket was mentioned in PR #6543 on WordPress/wordpress-develop by @sabernhardt.
9 months ago
#5
- Keywords has-patch added; needs-refresh removed
- Sets the
.wp-block-post-title
font sizes together withh2
. - Combines the
post-section-dash
mixin for bothh1
andh2
in the same rulesets.
#6
@
9 months ago
- Keywords needs-testing added; changes-requested removed
- Milestone changed from Future Release to 6.6
#7
@
9 months ago
Test Report
Patch Tested: https://github.com/WordPress/wordpress-develop/pull/6543
Environment:
WordPress - 6.5.3
OS - Windows
Browser - Firefox
Theme: Twenty Nineteen
PHP - 8.1.23
Actual Results:
- Page/Post Title's font size are showing same in Back-End & Front-End with Patch.✅
#8
@
9 months ago
- Owner set to karmatosed
- Resolution set to fixed
- Status changed from new to closed
In 58198:
#9
@
9 months ago
Thank you everyone for this work. I have moved this forward and committed after testing.
@sabernhardt commented on PR #6543:
7 months ago
#10
Committed in r58198
editor screenshot