Changes between Initial Version and Version 1 of Ticket #58443, comment 13
- Timestamp:
- 10/16/2023 12:02:34 PM (18 months ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #58443, comment 13
initial v1 1 Using `inherit` was not the best way to fix custom `line-height`. 1 ~~Using~~ //Switching a specific value to// `inherit` was not the best way to fix custom `line-height`. 2 //Correction: When the theme—or block library styles—specify the desired value on a **parent** element, then using `inherit` could be highly appropriate.// 2 3 3 4 On the front end, [https://github.com/WordPress/twentynineteen/blob/be850d11ee31434ad700db518ff8570f82e65b9c/sass/forms/_buttons.scss#L16 all button-like elements] have had a `line-height` of 1.2 since [https://github.com/WordPress/twentynineteen/blob/be850d11ee31434ad700db518ff8570f82e65b9c/sass/blocks/_blocks.scss#L130 initial commit], and it needs to stay that value when users do not select their own. This ticket did not change the front-end `style.css` and the RTL was reverted, so the current state is still only wrong with a custom `line-height`. … … 5 6 The editor's value of 1.8 did not match the front, but removing the entire line can be better than changing to `inherit`. 6 7 7 //Any// of the customizable properties probably could be moved to the `wp-block-button` or `wp-block-buttons` element instead of the link. 8 ~~Any~~ //Some// of the customizable properties probably could be moved to the `wp-block-button` or `wp-block-buttons` element instead of the link. 9 //Correction: The em-based `font-size` is one property that probably should **not** be moved to another element because that would change the size for anyone who has set a value in custom CSS or who is satisfied with the relative difference in size using the block setting.// 8 10 9 11 **If** tests are still giving any errors, that might be related to the missing space after the colon in `style-editor.scss`.