Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #58443, comment 26


Ignore:
Timestamp:
10/16/2023 01:44:02 PM (6 months ago)
Author:
sabernhardt
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #58443, comment 26

    initial v1  
    11I needed to edit two statements in #comment:13 because they were not entirely accurate.
    22
    3 PR 5431 is an improvement but not thorough. It adds support for the line height setting on the front end when applied to individual Button blocks, yet not when trying to set a line height on the parent Buttons block. Whether that is good enough or should be applied to `.wp-block-buttons` instead, I would like at least the same change in the theme's editor styles.
     3Thanks for the newer patch. PR 5431 is an improvement but not thorough. It adds support for the line height setting on the front end when applied to individual Button blocks, yet not when trying to set a line height on the parent Buttons block. Whether that is good enough or should be applied to `.wp-block-buttons` instead, I would like at least the same change in the theme's editor styles.
    44
    55For quicker testing, you could copy and paste a [https://gist.github.com/sabernhardt/942e36beed59b664db5c8803f57f08ec set of Button blocks]. The first set focuses on the default typography styles and custom line height, and the second set includes several other custom typography options (Twenty Nineteen still would not support a custom font weight or text decoration).