Make WordPress Core

Opened 12 months ago

Closed 11 months ago

Last modified 11 months ago

#58464 closed defect (bug) (fixed)

Typo: `overriden` -> `overridden`

Reported by: aristath's profile aristath Owned by: isabel_brison's profile isabel_brison
Milestone: 6.3 Priority: normal
Severity: trivial Version:
Component: General Keywords: has-patch
Focuses: Cc:

Description

Just a simple, common typo we have in a couple of places in our codebase.
This has been merged in Gutenberg (see https://github.com/WordPress/gutenberg/pull/48711), and this ticket is to backport these changes to Core.

Attachments (2)

58464.diff (3.6 KB) - added by nihar007 12 months ago.
There are few files where this typo exists. I changed all those
58464-2.diff (2.9 KB) - added by nihar007 12 months ago.
This is the final one

Download all attachments as: .zip

Change History (9)

This ticket was mentioned in PR #4555 on WordPress/wordpress-develop by @aristath.


12 months ago
#1

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/58464

Please note that there are a couple of other instances where overridden is typed incorrectly, but those instances are in files that are directly included from 3rd-party libraries, so these were not modified in this PR.

@nihar007
12 months ago

There are few files where this typo exists. I changed all those

#2 @aristath
12 months ago

There are few files where this typo exists. I changed all those

Please note that these additional instances are in files that are part of 3rd-party libraries - as noted in the PR. That is why they were not modified and were kept intact. 3rd-party libraries should be updated separately, in their own repositories and not as part of WP because that just makes maintenance easier when there is an updated version of those libraries.

@nihar007
12 months ago

This is the final one

#3 @nihar007
12 months ago

Understood.
Then I think you patch is perfect.

#4 @kapilpaul
11 months ago

@aristath agreed with your comment. PR looks good to me. Thanks

#5 @isabel_brison
11 months ago

  • Owner set to isabel_brison
  • Status changed from new to assigned

#6 @isabel_brison
11 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 55945:

General: fix overridden typos.

Fixes two typos in class-wp-theme-json.

Props Aristath, nihar007, kapilpaul, oandregal, krupalpanchal.
Fixes #58464.

@isabel_brison commented on PR #4555:


11 months ago
#7

Committed in r55945 / da008c7.

Note: See TracTickets for help on using tickets.