transient variable "doing_cron" cause a fatal error when the transient value is empty

[fzhantw]

In wp-includes/cron.php LINE: 855

<?php
        if ( $lock + WP_CRON_LOCK_TIMEOUT > $gmt_time ) {
                return false;
        }

This causes a fatal error when $lock is not an integer.
Therefore, we should make a type-checking beforehand.

Enviroment:

• WordPress 6.2.2
• PHP 8.1.19

What steps should be taken to consistently reproduce the problem?
The site randomly occurs fatal error when the transient value of "doing_cron" is empty.

Does the problem occur even when you deactivate all plugins and use the default theme?
No, I think plugin"Transients Manager 2.0.3" is related to this bug.

https://core.trac.wordpress.org/ticket/58471#ticket

Check the type of 'doing_cron'
If is not integer, assign it 0

[ankitmaru]

@nihar007 Thanks for your patch.
I tested it and it looks good to me.

Thanks

[nihar007]

@ankitmaru You welcome

@fzhantw Are you able to link your GitHub account and WordPress.org profile, this swill ensure you are correctly given credit ift his PR is merged. You can link your account at ​https://profiles.wordpress.org/me/profile/edit/group/1/

@fzhantw Are you able to link your GitHub account and WordPress.org profile, this swill ensure you are correctly given credit ift his PR is merged. You can link your account at ​https://profiles.wordpress.org/me/profile/edit/group/1/

@peterwilsoncc Sure! Linked already

Hi, my website encountered this bug today.
I'm wondering is it possible to merge this patch into main branch?
Is there anything else I should do?

[peterwilsoncc]

The ​linked pull request looks good to me.

[peterwilsoncc]

In 56553:

Cron: Cast doing_cron transient to a float.

Cast the doing_cron transient value to a float to prevent type errors if the transient is not set (in which case it returns false) or another unexpected type.

Props fzhantw, ankitmaru.
Fixes #58471.

Merged in r56553 / ​https://github.com/WordPress/wordpress-develop/commit/2453a6b57d9bfeb0a5a5d191044b42d24955995b