Twenty Seventeen: Box shadow on Site Logo block looks odd

[nkeller15]

Steps to reproduce:

1. Activate the Twenty Seventeen theme
2. Add the Site Logo block to any page or post and add an image
3. Make sure link to home setting is toggled on
4. Save and view on front end

[nkeller15]

editor screenshot

[nkeller15]

front end screenshot

[nkeller15]

patch

[nkeller15]

The height of the image is also not set properly until you adjust the size of the image in the editor, but I'm not sure how to resolve that

[sabernhardt]

editing blocks.css

[sabernhardt]

I would suggest the bigger problem is having a Site Logo block available in the post editor context. However, if there is a reason to add the site logo link within the post content, the patch should edit blocks.css to avoid changing anything for sites that use no blocks at all.

The :root .entry-content .wp-block-site-logo a.custom-logo-link selector has a high specificity to override the box shadow even in the dark theme.

[sabernhardt]

Related: #52716

[sabernhardt]

refreshed

[karmatosed]

Adding this as a potential candidate for testing and inclusion in the next release, thanks everyone.

[hmbashar]

Test Report

Description

This report validates whether the indicated patch works as expected.

Patch tested: 58474.2

Environment

• WordPress: 6.6-alpha-57778-src
• PHP: 8.3.8
• Server: nginx/1.25.4
• Database: mysqli (Server: 8.3.0 / Client: mysqlnd 8.3.8)
• Browser: Chrome 125.0.0.0
• OS: macOS
• Theme: Twenty Seventeen 3.6
• MU Plugins: None activated
• Plugins:
  • FakerPress 0.6.6
  • Test Reports 1.1.0

Actual Results

1. ✅ Issue resolved with patch.

Screenshots

​Before Patch

​After Patch

[rajinsharwar]

Test Report

Description

This report validates whether the indicated patch works as expected.

Patch tested: 58474.2

Environment

• WordPress: 6.6-beta2
• PHP: 8.3.0
• Server: nginx
• Database: mysqli
• Browser: Chrome
• OS: Windows
• Theme: Twenty Seventeen

Actual Results

1. ✅ Issue resolved with patch.

Screenshots

Before: ​https://img001.prntscr.com/file/img001/m5sryWgyRKe9ERqaPoNbwQ.png
After: ​https://img001.prntscr.com/file/img001/RsreRToHSo-tprzTgdYrCA.png

[huzaifaalmesbah]

Test Report

Description

Patch tested: 58474.2.patch​

Environment

• WordPress: 6.6-beta2-58392-src
• PHP: 8.3.7
• Server: nginx/1.25.5
• Database: mysqli (Server: 11.3.2-MariaDB / Client: mysqlnd 8.3.7)
• Browser: Chrome 125.0.0.0
• OS: macOS
• Theme: Twenty Seventeen 3.6
• MU Plugins: None activated
• Plugins:
  • Test Reports 1.1.0

Screenshots

Before Apply Patch	After Apply Patch ✅

[shailu25]

Test Report

Patch Tested: https://core.trac.wordpress.org/attachment/ticket/58474/58474.2.patch

Environment:

WordPress - 6.6 Beta 2
OS - Windows
Browser - Firefox
Theme: Twenty Seventeen
PHP - 8.2.12

Actual Results:

• Issue resolved with patch.✅

Supplemental Artifacts:

• Added Attachment

[shailu25]

Before Patch

[shailu25]

After Patch

[sabernhardt]

The situation is probably quite rare, but I think I can remove my request for a second opinion and move the ticket toward completion.

[SergeyBiryukov]

In 58426:

Twenty Seventeen: Correct image height for the Site Logo block.

Includes removing box shadow when the “Link image to home” setting is enabled.

Follow-up to [43800].

Props sabernhardt, nkeller15, karmatosed, hmbashar, rajinsharwar, huzaifaalmesbah, shailu25.
Fixes #58474.