Make WordPress Core

Opened 10 months ago

Last modified 10 months ago

#58474 new defect (bug)

Twenty Seventeen: Box shadow on Site Logo block looks odd

Reported by: nkeller15's profile nkeller15 Owned by:
Milestone: Awaiting Review Priority: normal
Severity: minor Version: 6.2.2
Component: Bundled Theme Keywords: has-patch 2nd-opinion
Focuses: css Cc:

Description

Steps to reproduce:

  1. Activate the Twenty Seventeen theme
  2. Add the Site Logo block to any page or post and add an image
  3. Make sure link to home setting is toggled on
  4. Save and view on front end

Attachments (4)

SCR-20230607-kdpp.png (87.2 KB) - added by nkeller15 10 months ago.
editor screenshot
SCR-20230607-kdrk.png (56.0 KB) - added by nkeller15 10 months ago.
front end screenshot
58474.patch (621 bytes) - added by nkeller15 10 months ago.
patch
58474.1.patch (701 bytes) - added by sabernhardt 10 months ago.
editing blocks.css

Download all attachments as: .zip

Change History (7)

@nkeller15
10 months ago

editor screenshot

@nkeller15
10 months ago

front end screenshot

@nkeller15
10 months ago

patch

#1 @nkeller15
10 months ago

  • Keywords has-patch added

The height of the image is also not set properly until you adjust the size of the image in the editor, but I'm not sure how to resolve that

@sabernhardt
10 months ago

editing blocks.css

#2 @sabernhardt
10 months ago

  • Keywords 2nd-opinion added
  • Summary changed from Twenty Seventeen - Box shadow on Site Logo block looks odd to Twenty Seventeen: Box shadow on Site Logo block looks odd

I would suggest the bigger problem is having a Site Logo block available in the post editor context. However, if there is a reason to add the site logo link within the post content, the patch should edit blocks.css to avoid changing anything for sites that use no blocks at all.

The :root .entry-content .wp-block-site-logo a.custom-logo-link selector has a high specificity to override the box shadow even in the dark theme.

Note: See TracTickets for help on using tickets.