![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
#58474 closed defect (bug) (fixed)
Twenty Seventeen: Box shadow on Site Logo block looks odd
| Reported by: | nkeller15 | Owned by: | SergeyBiryukov |
|---|---|---|---|
| Priority: | normal | Milestone: | 6.6 |
| Component: | Bundled Theme | Version: | 6.2.2 |
| Severity: | minor | Keywords: | has-patch has-test-info commit |
| Cc: | Focuses: | css |
Description
Steps to reproduce:
- Activate the Twenty Seventeen theme
- Add the Site Logo block to any page or post and add an image
- Make sure link to home setting is toggled on
- Save and view on front end
Attachments (7)
Change History (22)
#1
@
3 years ago
- Keywords has-patch added
The height of the image is also not set properly until you adjust the size of the image in the editor, but I'm not sure how to resolve that
#2
@
3 years ago
- Keywords 2nd-opinion added
- Summary Twenty Seventeen - Box shadow on Site Logo block looks odd → Twenty Seventeen: Box shadow on Site Logo block looks odd
I would suggest the bigger problem is having a Site Logo block available in the post editor context. However, if there is a reason to add the site logo link within the post content, the patch should edit blocks.css to avoid changing anything for sites that use no blocks at all.
The :root .entry-content .wp-block-site-logo a.custom-logo-link selector has a high specificity to override the box shadow even in the dark theme.
#8
@
2 years ago
- Milestone Future Release → 6.6
Adding this as a potential candidate for testing and inclusion in the next release, thanks everyone.
#9
@
2 years ago
Test Report
Description
This report validates whether the indicated patch works as expected.
Patch tested: 58474.2
Environment
- WordPress: 6.6-alpha-57778-src
- PHP: 8.3.8
- Server: nginx/1.25.4
- Database: mysqli (Server: 8.3.0 / Client: mysqlnd 8.3.8)
- Browser: Chrome 125.0.0.0
- OS: macOS
- Theme: Twenty Seventeen 3.6
- MU Plugins: None activated
- Plugins:
- FakerPress 0.6.6
- Test Reports 1.1.0
Actual Results
- ✅ Issue resolved with patch.
Screenshots
#10
@
2 years ago
- Keywords has-testing-info added
Test Report
Description
This report validates whether the indicated patch works as expected.
Patch tested: 58474.2
Environment
- WordPress: 6.6-beta2
- PHP: 8.3.0
- Server: nginx
- Database: mysqli
- Browser: Chrome
- OS: Windows
- Theme: Twenty Seventeen
Actual Results
- ✅ Issue resolved with patch.
Screenshots
Before: https://img001.prntscr.com/file/img001/m5sryWgyRKe9ERqaPoNbwQ.png
After: https://img001.prntscr.com/file/img001/RsreRToHSo-tprzTgdYrCA.png
#11
@
2 years ago
Test Report
Description
Patch tested: 58474.2.patch
Environment
- WordPress: 6.6-beta2-58392-src
- PHP: 8.3.7
- Server: nginx/1.25.5
- Database: mysqli (Server: 11.3.2-MariaDB / Client: mysqlnd 8.3.7)
- Browser: Chrome 125.0.0.0
- OS: macOS
- Theme: Twenty Seventeen 3.6
- MU Plugins: None activated
- Plugins:
- Test Reports 1.1.0
Screenshots
| Before Apply Patch | After Apply Patch ✅ |
 | 
|
#12
@
2 years ago
Test Report
Patch Tested: https://core.trac.wordpress.org/attachment/ticket/58474/58474.2.patch
Environment:
WordPress - 6.6 Beta 2
OS - Windows
Browser - Firefox
Theme: Twenty Seventeen
PHP - 8.2.12
Actual Results:
- Issue resolved with patch.✅
Supplemental Artifacts:
- Added Attachment
editor screenshot