Make WordPress Core

Opened 14 months ago

Closed 5 weeks ago

#58474 closed defect (bug) (fixed)

Twenty Seventeen: Box shadow on Site Logo block looks odd

Reported by: nkeller15's profile nkeller15 Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 6.6 Priority: normal
Severity: minor Version: 6.2.2
Component: Bundled Theme Keywords: has-patch has-testing-info commit
Focuses: css Cc:

Description

Steps to reproduce:

  1. Activate the Twenty Seventeen theme
  2. Add the Site Logo block to any page or post and add an image
  3. Make sure link to home setting is toggled on
  4. Save and view on front end

Attachments (7)

SCR-20230607-kdpp.png (87.2 KB) - added by nkeller15 14 months ago.
editor screenshot
SCR-20230607-kdrk.png (56.0 KB) - added by nkeller15 14 months ago.
front end screenshot
58474.patch (621 bytes) - added by nkeller15 14 months ago.
patch
58474.1.patch (701 bytes) - added by sabernhardt 14 months ago.
editing blocks.css
58474.2.patch (701 bytes) - added by sabernhardt 2 months ago.
refreshed
58474-before-patch.png (20.0 KB) - added by shailu25 5 weeks ago.
Before Patch
58474-after-patch.png (74.2 KB) - added by shailu25 5 weeks ago.
After Patch

Download all attachments as: .zip

Change History (21)

@nkeller15
14 months ago

editor screenshot

@nkeller15
14 months ago

front end screenshot

@nkeller15
14 months ago

patch

#1 @nkeller15
14 months ago

  • Keywords has-patch added

The height of the image is also not set properly until you adjust the size of the image in the editor, but I'm not sure how to resolve that

@sabernhardt
14 months ago

editing blocks.css

#2 @sabernhardt
14 months ago

  • Keywords 2nd-opinion added
  • Summary changed from Twenty Seventeen - Box shadow on Site Logo block looks odd to Twenty Seventeen: Box shadow on Site Logo block looks odd

I would suggest the bigger problem is having a Site Logo block available in the post editor context. However, if there is a reason to add the site logo link within the post content, the patch should edit blocks.css to avoid changing anything for sites that use no blocks at all.

The :root .entry-content .wp-block-site-logo a.custom-logo-link selector has a high specificity to override the box shadow even in the dark theme.

#4 @karmatosed
3 months ago

  • Keywords dev-feedback added

#5 @karmatosed
2 months ago

  • Keywords needs-testing added

#6 @karmatosed
2 months ago

  • Keywords needs-refresh added
  • Milestone changed from Awaiting Review to Future Release

@sabernhardt
2 months ago

refreshed

#7 @sabernhardt
2 months ago

  • Keywords needs-refresh removed

#8 @karmatosed
6 weeks ago

  • Milestone changed from Future Release to 6.6

Adding this as a potential candidate for testing and inclusion in the next release, thanks everyone.

#9 @hmbashar
5 weeks ago

Test Report

Description

This report validates whether the indicated patch works as expected.

Patch tested: 58474.2

Environment

  • WordPress: 6.6-alpha-57778-src
  • PHP: 8.3.8
  • Server: nginx/1.25.4
  • Database: mysqli (Server: 8.3.0 / Client: mysqlnd 8.3.8)
  • Browser: Chrome 125.0.0.0
  • OS: macOS
  • Theme: Twenty Seventeen 3.6
  • MU Plugins: None activated
  • Plugins:
    • FakerPress 0.6.6
    • Test Reports 1.1.0

Actual Results

  1. ✅ Issue resolved with patch.

Screenshots

Before Patch

After Patch

#10 @rajinsharwar
5 weeks ago

  • Keywords has-testing-info added

Test Report

Description

This report validates whether the indicated patch works as expected.

Patch tested: 58474.2

Environment

  • WordPress: 6.6-beta2
  • PHP: 8.3.0
  • Server: nginx
  • Database: mysqli
  • Browser: Chrome
  • OS: Windows
  • Theme: Twenty Seventeen

Actual Results

  1. ✅ Issue resolved with patch.

Screenshots

Before: https://img001.prntscr.com/file/img001/m5sryWgyRKe9ERqaPoNbwQ.png
After: https://img001.prntscr.com/file/img001/RsreRToHSo-tprzTgdYrCA.png

#11 @huzaifaalmesbah
5 weeks ago

Test Report

Description

Patch tested: 58474.2.patch

Environment

  • WordPress: 6.6-beta2-58392-src
  • PHP: 8.3.7
  • Server: nginx/1.25.5
  • Database: mysqli (Server: 11.3.2-MariaDB / Client: mysqlnd 8.3.7)
  • Browser: Chrome 125.0.0.0
  • OS: macOS
  • Theme: Twenty Seventeen 3.6
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.1.0

Screenshots

Before Apply Patch After Apply Patch ✅
https://i.ibb.co/M6Hv63X/Huzaifa-20240615075428.png https://i.ibb.co/XyMHBf4/Huzaifa-20240615075701.png

#12 @shailu25
5 weeks ago

Test Report

Patch Tested: https://core.trac.wordpress.org/attachment/ticket/58474/58474.2.patch

Environment:

WordPress - 6.6 Beta 2
OS - Windows
Browser - Firefox
Theme: Twenty Seventeen
PHP - 8.2.12

Actual Results:

  • Issue resolved with patch.✅

Supplemental Artifacts:

  • Added Attachment

@shailu25
5 weeks ago

Before Patch

@shailu25
5 weeks ago

After Patch

#13 @sabernhardt
5 weeks ago

  • Keywords commit added; 2nd-opinion dev-feedback needs-testing removed

The situation is probably quite rare, but I think I can remove my request for a second opinion and move the ticket toward completion.

#14 @SergeyBiryukov
5 weeks ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 58426:

Twenty Seventeen: Correct image height for the Site Logo block.

Includes removing box shadow when the “Link image to home” setting is enabled.

Follow-up to [43800].

Props sabernhardt, nkeller15, karmatosed, hmbashar, rajinsharwar, huzaifaalmesbah, shailu25.
Fixes #58474.

Note: See TracTickets for help on using tickets.