Add notice if no posts are selected in Bulk Edit

[sumitsingh]

On the Posts screen(s), clicking the bulk actions Apply button without selecting any posts does not show an error message.

1. Visit the Posts screen.
2. Choose "Edit" in the Bulk actions dropdown.
3. Without checking any checkboxes, click the Apply button. Nothing seems to happen.
4. Choose "Move to Trash" in the Bulk actions dropdown.
5. Click the Apply button. The page reloads but cannot move anything to Trash.
6. Choose "Bulk actions" at the top of the Bulk actions dropdown.
7. Click the Apply button. The page reloads with a query string in the URL.

I have checked and it should be a message on the page/post list as per added notice message on the plugin page.

For more information, you can see mentioned quick video.

Thank you

[sumitsingh]

here quick video for more clear about suggetion

[sumitsingh]

My suggetion

[sumitsingh]

existing example

[nihar007]

I added only "no post selected" alert

[sabernhardt]

Categories and Tags pages may need something similar, too (separate ticket?). Those pages reload without an error/notice if no items are selected.

[sumitsingh]

I think we can manage in this ticket @sabernhardt. Let me know if I need to create separate for other screen like this validation overall backed side.

[oglekler]

@sumitsingh and @joedolson, I wonder if the better approach is to disable button until something will be selected, otherwise page reload is pointless. And message needs to be appear close to button if person is trying to click it that nothing will be changed.

[joedolson]

See also #45006 and #31634, as well. Disabling the button was tried for 31634, but was not as great a solution as it seemed. There were a lot of accessibility problems.

This patch looks like it could use some refinement, as well.

1) This should probably be an inline admin notice. Then we don't need to disruptively change the viewport position for the user.
2) It should also use wp.a11y.speak so that there's a verbal announcements.

[quadthemes]

Adding inline admin notice to bulk action section would result in error being shown at both places(before and after the list). Though it's much better than scroll to top that is currently happening on plugins page. Any opinions? @joedolson

Replying to joedolson:

See also #45006 and #31634, as well. Disabling the button was tried for 31634, but was not as great a solution as it seemed. There were a lot of accessibility problems.

This patch looks like it could use some refinement, as well.

1) This should probably be an inline admin notice. Then we don't need to disruptively change the viewport position for the user.
2) It should also use wp.a11y.speak so that there's a verbal announcements.

[marybaum]

Can yall get this patch refined in a week? We will look at this again next Tuesday.

Trac ticket:
https://core.trac.wordpress.org/ticket/58479

[oglekler]

Thank you, @quadthemes for the patch. Let's test it.

[huzaifaalmesbah]

I've been trying to test and haven't noticed any changes.

[Ankit K Gupta]

Tested the patch ​https://github.com/WordPress/wordpress-develop/pull/5423 and it works as explained here:

Adding inline admin notice to bulk action section would result in error being shown at both places(before and after the list). Though it's much better than scroll to top that is currently happening on the plugins page.

Plugins Page After the patch:

Posts Page After the Patch:

IMO, just showing the message at the top is fine instead of showing the same message in two places on same screen.

Let's wait for another opinion.

[fnpen]

@ankit-k-gupta, I also see it only on the top of the page (Plugins), and does not work on posts page.

[fnpen]

This part of the features has a partial implementation for Plugins, but it does not show when action is not selected.

Also, we can select actions for Users and Change Roles where it is a similar requirement to pick rows. The plugins page shows only one notification on top and scrolls the page up.

Implementation:

• Covers cases of any list table with role selector and plugins page.
• Shows one notification when no action or item is selected

'addAdminNotice' will be a good idea to make it global and universal.

[oglekler]

We have RC1 tomorrow, so, I am moving this to the next milestone. Right now we can work further on the ticket, and it can land into the 6.5 as soon as it will be ready.