Opened 4 months ago
Last modified 2 weeks ago
#58485 assigned defect (bug)
Twenty Twenty-Three: Inline CSS - Unit of measure is redundant
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 6.4 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | has-patch |
Focuses: | css, template, coding-standards | Cc: |
Description
On a few pages, margin properties have not proper properties as per standards.
CS: Unit of measure is redundant
Change History (17)
This ticket was mentioned in PR #4567 on WordPress/wordpress-develop by @ankitmaru.
4 months ago
#1
#2
@
4 months ago
- Component changed from Themes to Bundled Theme
- Milestone changed from Awaiting Review to 6.3
- Summary changed from CS: Inline CSS - Unit of measure is redundant to Twenty Twenty-Three: Inline CSS - Unit of measure is redundant
#3
@
4 months ago
- Owner set to SergeyBiryukov
- Resolution set to fixed
- Status changed from new to closed
In 55898:
@SergeyBiryukov commented on PR #4567:
4 months ago
#4
Thanks for the PR! Merged in r55898.
#5
@
4 months ago
- Resolution fixed deleted
- Status changed from closed to reopened
I haven't tested this, but couldn't this trigger a "block content has changed" warning/error on existing sites? Or wait, rather wouldn't the extra units be coming back as they are still part of the block attributes?
#6
@
3 months ago
Hi
This does not cause any validation errors for the block markup in the editor, but I would prefer for it to be reverted:
1) The values in the block comment and the style
attribute needs to match. It did not cause a block validation this time, but if it had been a different block attribute like class name or tag name, the mismatch would have caused an error.
2) The block control does not accept unitless values. If we would solve the mismatch and remove the unit from both the comment and the markup, then the block control
in the editor would not display the correct value. I believe this may be why the unit is not removed by the editor when it prepares the CSS.
This ticket was mentioned in Slack in #core by oglekler. View the logs.
3 months ago
#8
@
3 months ago
@SergeyBiryukov can you address the comment from Carolina?
I browsed the code, and it looks like 0px or 0rem in TwentyTwo theme all over the place, but it is only there. And here is a good point that block attributes and actual block needs to be match. 🤔
This ticket was mentioned in Slack in #core by audrasjb. View the logs.
2 months ago
This ticket was mentioned in Slack in #core by oglekler. View the logs.
2 months ago
#11
@
2 months ago
This ticket was discussed during a bug scrub, and comment from @audrasjb: "Given we’re so close to the RC cycle, let’s revert it for now, then move it to milestone 6.4"
This ticket was mentioned in Slack in #core by audrasjb. View the logs.
2 months ago
#13
@
2 months ago
- Owner changed from SergeyBiryukov to audrasjb
- Status changed from reopened to assigned
As per today's bug scrub: self assigning for revert.
Inline CSS fixes on a few templates.
Trac ticket: https://core.trac.wordpress.org/ticket/58485
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.