Make WordPress Core

Opened 4 months ago

Last modified 2 weeks ago

#58498 assigned defect (bug)

Twenty Fifteen: Cover and File blocks spacing

Reported by: mayur8991's profile mayur8991 Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 6.2.2
Component: Bundled Theme Keywords: has-testing-info
Focuses: css Cc:

Description

Backend : https://prnt.sc/iMIHui1cpt-v
Frontend : https://prnt.sc/1Y5xpMmMWc9E

How to reproduce bug

  • Activate Twenty Fifteen Theme
  • Add new page then Add cover block and just below it Add File widget
  • Save the page and check frontend

Enviornment

PHP : 8
Wordpress : 6.2.2
Theme : Twenty Fifteen Version 3.4
Browser : Chrome
OS : Window

Note : This bug only appear in Twenty Fifteen Theme and in rest of the bundled themes it looks great & UI issue only appear when we choose this two widgets only if you choose any other widget it will look proper

Attachments (3)

frontend.jpg (84.4 KB) - added by mayur8991 4 months ago.
backend.jpg (128.4 KB) - added by mayur8991 4 months ago.
58498.diff (439 bytes) - added by itpathsolutions 2 weeks ago.
Patch added

Download all attachments as: .zip

Change History (8)

@mayur8991
4 months ago

@mayur8991
4 months ago

#1 @panchalhimani711
4 months ago

@mayur8991

can be fix with css

.wp-block-cover { margin-bottom: 1em; }
Last edited 4 months ago by panchalhimani711 (previous) (diff)

#2 @sabernhardt
3 months ago

  • Focuses ui removed
  • Summary changed from Twenty Fifteen Theme - Cover and file widget UI Issue to Twenty Fifteen: Cover and File blocks spacing

If you mean that the Cover block overlaps the File block download link, that should be fixed by the addition of display: inline-block in GB41870.

If you want space between the blocks, that would be another matter. In the editor, blocks have space in between them to make room for the inserter that appears when you hover the cursor above it. On the front, blocks such as Cover, Group or Columns probably should not have margins automatically. File blocks should have some space; they have a default bottom margin of 1.5em but for some reason do not have the same on top. I think that would be better to address this in the File block styles than in individual themes.

#3 @mayur8991
2 months ago

  • Keywords needs-patch needs-testing added

@itpathsolutions
2 weeks ago

Patch added

#4 @itpathsolutions
2 weeks ago

  • Keywords needs-patch removed

Added patch

#5 @thakordarshil
2 weeks ago

  • Keywords has-testing-info added; needs-testing removed

Hi

Test report for - https://core.trac.wordpress.org/attachment/ticket/58498/58498.diff patch
Environment : PHP 8
WordPress - 6.2.2 & 6.3.1
Theme - Twenty Fifteen Version: 3.5
Os: Windows
Browser: Chrome
Expected Result: There should be space between cover widget and file widget

Before Patch

Backend - https://prnt.sc/7G6HVzUhnAcB
Frontend - https://prnt.sc/cbAX_gSMRsRq

After Patch
Backend - https://prnt.sc/YWPyJhvc5oQ4
Frontend - https://prnt.sc/2xJIrbWN6jVk

Thanks!

Note: See TracTickets for help on using tickets.