Make WordPress Core

Opened 13 months ago

Last modified 2 weeks ago

#58500 new defect (bug)

Twenty Twenty: Separator block's Default style is wider than Wide Line style in editor

Reported by: nidhidhandhukiya's profile nidhidhandhukiya Owned by:
Milestone: Awaiting Review Priority: normal
Severity: minor Version: 6.2.2
Component: Bundled Theme Keywords: has-patch needs-testing
Focuses: css Cc:

Description

Steps to reproduce the issue.

  1. Activate Twenty Twenty theme.
  2. Take separator block.
  3. Choose wide-width and check that editor and front both side.

In front side default and wide width working as expected but in editor side it not works proper.

I have attached video for better understanding.
Video URL :- https://share.cleanshot.com/xLbqrymSPhRf1kPpSw7B

Attachments (5)

58500.diff (1.1 KB) - added by sabernhardt 13 months ago.
LTR-800-front.png (6.3 KB) - added by sabernhardt 13 months ago.
On larger screens, the Default style lines up with the margin of a paragraph block, and the Wide Line separator approaches the edge of the window on the front end.
LTR-800-editor.png (32.6 KB) - added by sabernhardt 13 months ago.
With the patch in the editor, the Default style lines up with the margin of a paragraph block, and the Wide Line separator gets closer to the edge (than it does on the front).
LTR-600-front.png (4.4 KB) - added by sabernhardt 13 months ago.
On smaller screens, the front end shows both the Default and Wide Line separators aligned with the margin of a paragraph block.
LTR-600-editor.png (24.3 KB) - added by sabernhardt 13 months ago.
With the patch, the editor also shows both the Default and Wide Line separators aligned with the margin of a paragraph block.

Download all attachments as: .zip

Change History (9)

#1 @sabernhardt
13 months ago

  • Focuses css added
  • Summary changed from Twenty Twenty theme separator block is having issue in editor with default and wide-width layout. to Twenty Twenty: Separator block's Default style is wider than Wide Line style in editor

@sabernhardt
13 months ago

@sabernhardt
13 months ago

On larger screens, the Default style lines up with the margin of a paragraph block, and the Wide Line separator approaches the edge of the window on the front end.

@sabernhardt
13 months ago

With the patch in the editor, the Default style lines up with the margin of a paragraph block, and the Wide Line separator gets closer to the edge (than it does on the front).

@sabernhardt
13 months ago

On smaller screens, the front end shows both the Default and Wide Line separators aligned with the margin of a paragraph block.

@sabernhardt
13 months ago

With the patch, the editor also shows both the Default and Wide Line separators aligned with the margin of a paragraph block.

#2 @sabernhardt
13 months ago

  • Keywords has-patch added

The Default style's max-width was necessary with WordPress 5.3 to override the 100px size from the editor. That is not necessary anymore, and the hr element is no longer inside a div to hold it to the standard .wp-block width of 610px. I added 610px as the max-width for this style of the Separator block.

The Wide Line style is not quite 100% on the front end (100vw - 8rem), but I used 100% in the editor for both width and max-width so it would not be narrower than the Default style.

#3 @sabernhardt
13 months ago

Oops. You said the "Wide width" alignment option, not the "Wide Line" style. The patch might still work, or at least be closer, but alignment options are not included in the screenshots.

#4 @karmatosed
2 weeks ago

  • Keywords needs-testing added
Note: See TracTickets for help on using tickets.