Opened 16 months ago
Last modified 16 months ago
#58501 new defect (bug)
Need to change in docs comment in xmlrpc.php
Reported by: | hiren1094 | Owned by: | |
---|---|---|---|
Milestone: | Awaiting Review | Priority: | normal |
Severity: | normal | Version: | |
Component: | General | Keywords: | has-patch reporter-feedback |
Focuses: | docs | Cc: |
Description
Hello,
Need to change below the comment for this "logIO()" function.
Need to change comment "logIO() - Writes logging info to a file." line and It should be "Writes logging info to a file - logIO()." Also, add a full stop in the last for this line "@param string $io Whether input or output"
As per phpcs coding standard.
Attachments (1)
Change History (6)
#2
@
16 months ago
- Keywords reporter-feedback added
Hello and thanks for the ticket,
Could you please quickly explain why "Writes logging info to a file - logIO()." would be better or more understandable than "logIO() - Writes logging info to a file."? Thanks!
#3
follow-up:
↓ 4
@
16 months ago
Hello @audrasjb,
As per phpcs standard, Doc comment short description must start with a capital letter so that's why I have changed the sequence because we don't change function name in comment.
#4
in reply to:
↑ 3
@
16 months ago
Replying to hiren1094:
As per phpcs standard, Doc comment short description must start with a capital letter so that's why I have changed the sequence because we don't change function name in comment.
I think this rule actually doesn't apply to PHP functions, proper nouns or other nouns that need to be written with a first lowercase letter.
Patch Added