WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#58510 closed enhancement (fixed)

Add fetchpriority attribute to wp_preload_resources

Reported by: luboslives Owned by: adamsilverstein
Priority: normal Milestone: 6.6
Component: General Version: 6.1
Severity: normal Keywords: has-unit-tests has-patch
Cc: Focuses: performance

Description

The ​wp_preload_resources filter only allows for a small set of attributes. Please add the ​fetchpriority attribute to that list. I see fetchpriority is being discussed, but not in regards to this particular filter.

Attachments (1)

58510.diff​ (2.4 KB ) - added by nihar007 3 years ago.
I added the fetchpriority attribute

Download all attachments as: .zip

Change History (10)

@nihar007
3 years ago

I added the fetchpriority attribute

This ticket was mentioned in ​PR #5991 on ​WordPress/wordpress-develop by ​@tabrisrp.
3 years ago #1

  • Keywords has-patch has-unit-tests added

Add support for the fetchpriority attribute in wp_preload_resources()

Trac ticket: https://core.trac.wordpress.org/ticket/58510

#2 @tabrisrp
3 years ago

  • Keywords has-patch has-unit-tests → has-unit-tests has-patch

Added a pull request on Github for this enhancement, which includes update of the unit tests too to validate the change.

#3 @adamsilverstein
3 years ago

  • Owner set to adamsilverstein
  • Status new → assigned
  • Version → 6.1

This ticket was mentioned in ​PR #6231 on ​WordPress/wordpress-develop by ​@adamsilverstein.
3 years ago #4

Trac ticket:

#5 @adamsilverstein
3 years ago

  • Resolution → fixed
  • Status assigned → closed

In 57789:

Script loader: enable fetchpriority attribute in the wp_preload_resources filter.

Add fetchpriority to the attributes accepted by the wp_preload_resources filter. Developers can now use this filter to set fetchpriority for resources being preloaded.

Props nihar007, luboslives, tabrisrp.
Fixes #58510.

#6 @kebbet
3 years ago

@adamsilverstein This ticket is in the Awaiting Review milestone, please milestone it to 6.6 (or 6.5 if this should be included and backported to that branch). Thanks!

#7 @adamsilverstein
3 years ago

  • Milestone Awaiting Review → 6.6

#8 @adamsilverstein
3 years ago

Thanks for catching @kebbet - milestoned for 6.6.

Note: See TracTickets for help on using tickets.