Opened 3 years ago
Closed 2 years ago
#58522 closed enhancement (fixed)
Fluid typography: use layout.wideSize as max viewport width
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 6.3 | Priority: | normal |
| Severity: | normal | Version: | 6.3 |
| Component: | Editor | Keywords: | has-unit-tests has-patch |
| Focuses: | Cc: |
Description
Let's use the value of settings.layout.wideSize, if set, as the maximum viewport width for fluid font size calculations.
The default value is 1600px.
Added to the Gutenberg plugin in https://github.com/WordPress/gutenberg/pull/49815
See https://github.com/WordPress/gutenberg/pull/49707#pullrequestreview-1384094487 (review) for context
Slated for WordPress 6.3 and tracked in the backport issue: https://github.com/WordPress/gutenberg/issues/51077
Change History (14)
This ticket was mentioned in PR #4604 on WordPress/wordpress-develop by @ramonopoly.
3 years ago
#1
- Keywords has-patch added
@ramonopoly commented on PR #4604:
2 years ago
#3
Thanks for testing @tellthemachines
I assume the changes from https://github.com/WordPress/gutenberg/pull/51516 aren't testable until the npm packages are updated?
Yes. Thanks for mentioning that. I've updated the test description.
Note to self: if this gets merged, I'll update the tests for https://github.com/WordPress/wordpress-develop/pull/4605 (which will be affected due to the change in the way we calculate max viewport size)
#7
@
2 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
The docblock for the test is pointing to a function called gutenberg_apply_typography_support. Is that meant to be wp_apply_typography_support ? See the docblock in the test.
#8
@
2 years ago
@isabel_brison I believe that you can easily address a question and improve docblock. Thank you 🙏
#9
@
2 years ago
@isabel_brison I believe that you can easily address a question and improve docblock. Thank you 🙏
I can get a patch up for this later today. Thanks for spotting!
This ticket was mentioned in PR #4732 on WordPress/wordpress-develop by @ramonopoly.
2 years ago
#10
Rename gutenberg_apply_typography_support to gwp_apply_typography_support in comments
See comment: https://core.trac.wordpress.org/ticket/58522#comment:7
Trac ticket: https://core.trac.wordpress.org/ticket/58522
Let's use the value of
settings.layout.wideSize, if set, as the maximum viewport width for fluid font size calculations.The default value is
1600px.Added to the Gutenberg plugin in https://github.com/WordPress/gutenberg/pull/49815
### Testing
npm run test:php -- --filter Tests_Block_Supports_TypographyTrac ticket: https://core.trac.wordpress.org/ticket/58522