Make WordPress Core

Opened 10 months ago

Closed 10 months ago

Last modified 8 months ago

#58530 closed defect (bug) (duplicate)

HTML API: Introduce spacing to unlock linter in Gutenberg backport

Reported by: dmsnell's profile dmsnell Owned by: bernhard-reiter's profile Bernhard Reiter
Milestone: 6.3 Priority: normal
Severity: blocker Version: 6.2
Component: HTML API Keywords: has-patch commit
Focuses: Cc:

Description

When backporting the Tag Processor updates into Gutenberg for the 6.2 branch,
the CI job in Github rejected the backport because the linting rules differ
between the repositories.

Accepted and merged code shouldn't be rejected, but it was, and this change
is meant to unlock merging the backport.

cc: @hellofromtonya @sergeybiryukov

Change History (9)

This ticket was mentioned in PR #4610 on WordPress/wordpress-develop by @dmsnell.


10 months ago
#1

Trac: 58530-ticket

When backporting the Tag Processor updates into Gutenberg for the 6.2 branch,
the CI job in Github rejected the backport because the linting rules differ
between the repositories.

Accepted and merged code shouldn't be rejected, but it was, and this change
is meant to unlock merging the backport.

#2 @Bernhard Reiter
10 months ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 6.2.3

Setting the milestone to 6.2.3, as this is specifically for consistency with the Gutenberg plugin's WP 6.2 compatibility layer.

#3 @Bernhard Reiter
10 months ago

Ah, looks like trunk already has this change: https://core.trac.wordpress.org/browser/trunk/src/wp-includes/html-api/class-wp-html-tag-processor.php#L1933

So we really only need to apply it to the 6.2 branch.

#4 @Bernhard Reiter
10 months ago

Ah, we actually had a dedicated changeset for this in trunk: https://core.trac.wordpress.org/changeset/55674

#5 follow-up: @dmsnell
10 months ago

Thanks for catching that @bernhard-reiter - I didn't know if we needed a separate ticket and patch for it. My attempt as indicating this was to mark it against 6.2

#6 @Bernhard Reiter
10 months ago

  • Owner set to Bernhard Reiter
  • Resolution set to fixed
  • Status changed from new to closed

In 55925:

HTML API: Update code style so it passes when backported into Gutenberg.

This changes the indentation of a variable in class-wp-html-tag-processor.php
to satisfy both WordPress and Gutenberg linters.

Props dmsnell, zieladam, ntsekouras.
Merges [55674] to the 6.2 branch.
Fixes #58530.

#7 in reply to: ↑ 5 @Bernhard Reiter
10 months ago

Replying to dmsnell:

Thanks for catching that @bernhard-reiter - I didn't know if we needed a separate ticket and patch for it. My attempt as indicating this was to mark it against 6.2

Sorry, I only saw your message after committing.

No worries! FWIW, it would've been enough to re-open and re-use the old ticket (as done e.g. here) :)

Anyway, I ended up re-using the old commit message (and referenced the changeset in the new commit), in order to connect them as per convention :)

@Bernhard Reiter commented on PR #4610:


10 months ago
#8

Committed to Core's 6.2 branch in `r55925`.

Turns out we had a dedicated changeset to fix this in trunk, so I ended up re-using that commit's message (and referencing the changeset) in order to properly connect them to each other 😊

#9 @SergeyBiryukov
8 months ago

  • Milestone changed from 6.2.3 to 6.3
  • Resolution changed from fixed to duplicate

Looks like this was addressed for trunk in [55674] / #58170, and backported to the 6.2 branch in [55925].

Closing this ticket as a duplicate, as there are no plans for 6.2.3 at this time.

Last edited 8 months ago by SergeyBiryukov (previous) (diff)
Note: See TracTickets for help on using tickets.