#58530 closed defect (bug) (duplicate)
HTML API: Introduce spacing to unlock linter in Gutenberg backport
| Reported by: | dmsnell | Owned by: | Bernhard Reiter |
|---|---|---|---|
| Priority: | normal | Milestone: | 6.3 |
| Component: | HTML API | Version: | 6.2 |
| Severity: | blocker | Keywords: | has-patch commit |
| Cc: | Focuses: |
Description
When backporting the Tag Processor updates into Gutenberg for the 6.2 branch,
the CI job in Github rejected the backport because the linting rules differ
between the repositories.
Accepted and merged code shouldn't be rejected, but it was, and this change
is meant to unlock merging the backport.
cc: @hellofromtonya @sergeybiryukov
Change History (9)
This ticket was mentioned in PR #4610 on WordPress/wordpress-develop by @dmsnell.
3 years ago
#1
#2
@
3 years ago
- Keywords commit added
- Milestone Awaiting Review → 6.2.3
Setting the milestone to 6.2.3, as this is specifically for consistency with the Gutenberg plugin's WP 6.2 compatibility layer.
#3
@
3 years ago
Ah, looks like trunk already has this change: https://core.trac.wordpress.org/browser/trunk/src/wp-includes/html-api/class-wp-html-tag-processor.php#L1933
So we really only need to apply it to the 6.2 branch.
#4
@
3 years ago
Ah, we actually had a dedicated changeset for this in trunk: https://core.trac.wordpress.org/changeset/55674
#5
follow-up:
↓ 7
@
3 years ago
Thanks for catching that @bernhard-reiter - I didn't know if we needed a separate ticket and patch for it. My attempt as indicating this was to mark it against 6.2
#7
in reply to: ↑ 5
@
3 years ago
Replying to dmsnell:
Thanks for catching that @bernhard-reiter - I didn't know if we needed a separate ticket and patch for it. My attempt as indicating this was to mark it against 6.2
Sorry, I only saw your message after committing.
No worries! FWIW, it would've been enough to re-open and re-use the old ticket (as done e.g. here) :)
Anyway, I ended up re-using the old commit message (and referenced the changeset in the new commit), in order to connect them as per convention :)
@Bernhard Reiter commented on PR #4610:
3 years ago
#8
Committed to Core's 6.2 branch in `r55925`.
Turns out we had a dedicated changeset to fix this in trunk, so I ended up re-using that commit's message (and referencing the changeset) in order to properly connect them to each other 😊
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
Trac: 58530-ticket
When backporting the Tag Processor updates into Gutenberg for the 6.2 branch,
the CI job in Github rejected the backport because the linting rules differ
between the repositories.
Accepted and merged code shouldn't be rejected, but it was, and this change
is meant to unlock merging the backport.