Make WordPress Core

Opened 12 months ago

Closed 12 months ago

Last modified 12 months ago

#58549 closed enhancement (fixed)

Block Supports: Add text columns (column count) to typography block supports

Reported by: ramonopoly's profile ramonopoly Owned by: isabel_brison's profile isabel_brison
Milestone: 6.3 Priority: normal
Severity: normal Version: 6.3
Component: Editor Keywords: has-patch has-unit-tests gutenberg-merge
Focuses: Cc:

Description

Add a new block support feature to the typography toolset to allow control over CSS column count for blocks displaying multiline text.

Gutenberg PR that introduces this change in the plugin: https://github.com/WordPress/gutenberg/pull/33587

This allows further design possibilities.

https://user-images.githubusercontent.com/908665/93613659-0f615080-f9c9-11ea-8480-94d80ee6d2ad.png

Change History (8)

This ticket was mentioned in PR #4622 on WordPress/wordpress-develop by @ramonopoly.


12 months ago
#1

  • Keywords has-patch has-unit-tests added

This PR adds the PHP changes for the following Gutenberg PR:

Frontend changes also need to be ported and will be done before WP 6.3 beta (before June 27)

Testing:

npm run test:php -- --filter Tests_Theme_wpThemeJson

#2 @ramonopoly
12 months ago

  • Keywords gutenberg-merge added
  • Type changed from defect (bug) to enhancement
  • Version set to trunk

#3 @isabel_brison
12 months ago

  • Milestone changed from Awaiting Review to 6.3

@ramonopoly commented on PR #4622:


12 months ago
#4

@aaronrobertshaw do these ported changes look okay to you?

@aaronrobertshaw commented on PR #4622:


12 months ago
#5

Thank you for wrangling this backport @ramonjd

I think we might need to also backport the addition of textColumns support to the style engine which was added to Gutenberg in https://github.com/WordPress/gutenberg/pull/46566. As it's all for one feature, should that be part of this backport or separate?

The changes in this PR look good in terms of addressing https://github.com/WordPress/gutenberg/pull/33587 though.

@ramonopoly commented on PR #4622:


12 months ago
#6

I think we might need to also backport the addition of textColumns support to the style engine which was added to Gutenberg in https://github.com/WordPress/gutenberg/pull/46566.

Good spotting. I'll add it to this PR. 👍

thanks

#7 @isabel_brison
12 months ago

  • Owner set to isabel_brison
  • Resolution set to fixed
  • Status changed from new to closed

In 55985:

Editor: add text columns to typography support.

Adds a text columns feature to the typography block support that uses CSS column-count for multi-column text.

Props ramonopoly, aaronrobertshaw.
Fixes #58549.

@isabel_brison commented on PR #4622:


12 months ago
#8

Committed in r55985 / 9a9a672.

Note: See TracTickets for help on using tickets.