Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#58549 closed enhancement (fixed)

Block Supports: Add text columns (column count) to typography block supports

Reported by: ramonopoly Owned by: isabel_brison
Priority: normal Milestone: 6.3
Component: Editor Version: 6.3
Severity: normal Keywords: has-patch has-unit-tests gutenberg-merge
Cc: Focuses:

Description

Add a new block support feature to the typography toolset to allow control over CSS column count for blocks displaying multiline text.

Gutenberg PR that introduces this change in the plugin: ​https://github.com/WordPress/gutenberg/pull/33587

This allows further design possibilities.

https://user-images.githubusercontent.com/908665/93613659-0f615080-f9c9-11ea-8480-94d80ee6d2ad.png

Change History (8)

This ticket was mentioned in ​PR #4622 on ​WordPress/wordpress-develop by ​@ramonopoly.


3 years ago
#1

  • Keywords has-patch has-unit-tests added

This PR adds the PHP changes for the following Gutenberg PR:

Frontend changes also need to be ported and will be done before WP 6.3 beta (before June 27)

Testing:

npm run test:php -- --filter Tests_Theme_wpThemeJson

#2 @ramonopoly
3 years ago

  • Keywords gutenberg-merge added
  • Type defect (bug) → enhancement
  • Version → trunk

#3 @isabel_brison
3 years ago

  • Milestone Awaiting Review → 6.3

​@ramonopoly commented on ​PR #4622:


3 years ago
#4

@aaronrobertshaw do these ported changes look okay to you?

​@aaronrobertshaw commented on ​PR #4622:


3 years ago
#5

Thank you for wrangling this backport @ramonjd

I think we might need to also backport the addition of textColumns support to the style engine which was added to Gutenberg in ​https://github.com/WordPress/gutenberg/pull/46566. As it's all for one feature, should that be part of this backport or separate?

The changes in this PR look good in terms of addressing ​https://github.com/WordPress/gutenberg/pull/33587 though.

​@ramonopoly commented on ​PR #4622:


3 years ago
#6

I think we might need to also backport the addition of textColumns support to the style engine which was added to Gutenberg in ​https://github.com/WordPress/gutenberg/pull/46566.

Good spotting. I'll add it to this PR. 👍

thanks

#7 @isabel_brison
3 years ago

  • Owner set to isabel_brison
  • Resolution → fixed
  • Status new → closed

In 55985:

Editor: add text columns to typography support.

Adds a text columns feature to the typography block support that uses CSS column-count for multi-column text.

Props ramonopoly, aaronrobertshaw.
Fixes #58549.

​@isabel_brison commented on ​PR #4622:


3 years ago
#8

Committed in r55985 / ​9a9a672.

Note: See TracTickets for help on using tickets.