WordPress.org

Make WordPress Core

Opened 12 years ago

Closed 12 years ago

#5855 closed enhancement (fixed)

Optimize generic_ping function

Reported by: fitztrev Owned by:
Milestone: 2.5 Priority: low
Severity: normal Version:
Component: Optimization Keywords: has-patch
Focuses: Cc:
PR Number:

Description

The generic_ping function currently sends weblog_ping() a null value if there is an empty line in the ping_sites option. The regexp pattern in the function only replaces 2 or more empty lines with 1--it doesn't get rid of it altogether. There's no check anywhere down the line to stop the IXR class from trying to ping an empty string.

This restructure will address this problem and speed the function up at the same time.

Attachments (1)

generic-ping.diff (689 bytes) - added by fitztrev 12 years ago.
Don't ping empty strings.

Download all attachments as: .zip

Change History (3)

@fitztrev
12 years ago

Don't ping empty strings.

#1 @lloydbudd
12 years ago

  • Keywords has-patch added

#2 @ryan
12 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [6853]) generic_ping() improvements from fitztrev. fixes #5855

Note: See TracTickets for help on using tickets.