WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#58554 closed enhancement (fixed)

Add new grid layout type

Reported by: isabel_brison Owned by: isabel_brison
Priority: normal Milestone: 6.3
Component: General Version: 6.3
Severity: normal Keywords: gutenberg-merge has-patch
Cc: Focuses:

Description

Add a new grid type to the layout block support, as per Gutenberg ​https://github.com/WordPress/gutenberg/pull/49018 and including the update to layout.php from ​https://github.com/WordPress/gutenberg/pull/49050. (There will be a separate ticket for the compatibility updates to class-wp-theme-json from ​https://github.com/WordPress/gutenberg/pull/49050.)

Change History (7)

This ticket was mentioned in ​PR #4625 on ​WordPress/wordpress-develop by ​@isabel_brison.
3 years ago #1

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/58554

Introduces the PHP changes from ​https://github.com/WordPress/gutenberg/pull/49018 (except for the kses filter which will be dealt with separately) and the changes to layout.php from ​https://github.com/WordPress/gutenberg/pull/49050, because they build upon the changes from the first PR.

#2 @isabel_brison
3 years ago

  • Owner set to isabel_brison
  • Resolution → fixed
  • Status new → closed

In 55957:

Editor: add grid layout type

Add a new grid type to the layout block support.

Props andrewserong, costdev, ramonopoly.
Fixes #58554.

#3 @isabel_brison
3 years ago

In 55958:

Editor: revert add grid layout type

Reverting the previous commit because it causes e2e to fail on trunk.

See #58554.

#4 @isabel_brison
3 years ago

  • Resolution fixed
  • Status closed → reopened

​@isabel_brison commented on ​PR #4625:
3 years ago #5

Finally got e2e to pass on this branch so will try committing again 🤞

#6 @isabel_brison
3 years ago

  • Resolution → fixed
  • Status reopened → closed

In 55975:

Editor: add grid layout type

Add a new grid type to the layout block support.

Props andrewserong, costdev, ramonopoly.
Fixes #58554.

​@isabel_brison commented on ​PR #4625:
3 years ago #7

Thanks for the reviews folks!

Committed in r55975 / ​6188537.

Note: See TracTickets for help on using tickets.