#58556 closed task (blessed) (fixed)
Backport: Navigation Post Preloading in Site Editor
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 6.3 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Editor | Keywords: | gutenberg-merge has-patch commit |
Focuses: | Cc: |
Description
This ticket is to track the work to backport the preloading of Navigation Posts in the Site Editor.
Change History (15)
This ticket was mentioned in PR #4628 on WordPress/wordpress-develop by @get_dave.
21 months ago
#2
- Keywords has-patch added
#3
@
21 months ago
I have several changes related to "Navigation" in 6.3. These don't currently reside in the same file in the Gutenberg Plugin.
Is it better to:
- Combine all these files into a single file for inclusion in Core?
- Retain individual files for individual sub-features of the "Navigation" feature?
#4
@
21 months ago
- Milestone changed from Awaiting Review to 6.3
- Type changed from defect (bug) to enhancement
@spacedmonkey commented on PR #4628:
21 months ago
#5
@getdave This new file needs to be loaded in wp-settings.php
#6
@
21 months ago
@get_dave The PR you have doesn't make sense in core.
Instead of using that filter, just adding the new paths here. New need for a filter or new file.
@get_dave commented on PR #4628:
21 months ago
#7
Understood. My first time doing backports. Let me get this sorted.
@spacedmonkey commented on PR #4628:
21 months ago
#8
Understood. My first time doing backports. Let me get this sorted.
@getdave See my feedback on trac ticket before continuing.
@get_dave commented on PR #4628:
21 months ago
#9
Preload paths for Navigation have now be inlined directly in the Site Editor file as per recommendations.
@get_dave commented on PR #4628:
21 months ago
#11
Not sure what's going on with the CI tests here.
I believe I now wait for a Core Committer to merge this?
@ramonopoly commented on PR #4628:
21 months ago
#12
I believe I now wait for a Core Committer to merge this?
Yes! If @tellthemachines can't get to it today, hopefully someone will sweep in tonight and commit.
Thanks again!
#13
@
21 months ago
- Type changed from enhancement to task (blessed)
Converting to a task as this can ship after beta 1 is released.
Adds a
navigation.php
file to hold all hooks/utilites relating to Navigation in the Block Editor.Backports over the preloading hook for Navigation Posts.
Trac ticket: https://core.trac.wordpress.org/ticket/58556