Backport: Navigation Fallbacks

[get_dave]

Tracking ticket for work to backport Navigation Fallbacks code.

See ​https://github.com/WordPress/gutenberg/issues/51077 and ​https://github.com/WordPress/wordpress-develop/pull/4891

Adds files relating to Navigation fallbacks for the block editor.

Trac ticket: https://core.trac.wordpress.org/ticket/58557

@getdave Friendly reminder, changes like this need unit tests. Please ensure to backport / add unit tests.

This will also need the unit tests that currently reside in:

• ​https://github.com/WordPress/gutenberg/blob/trunk/phpunit/class-wp-classic-to-block-menu-converter-test.php
• ​https://github.com/WordPress/gutenberg/blob/trunk/phpunit/class-wp-rest-navigation-fallback-controller-test.php
• ​https://github.com/WordPress/gutenberg/blob/trunk/phpunit/class-wp-navigation-fallback-gutenberg-test.php

All classes, methods and function will need a @since 6.3.0.

@getdave Friendly reminder, changes like this need unit tests. Please ensure to backport / add unit tests.

Yep thanks. ​We have a suite already and I'm working out how/where to port them now.

I'm also trying to work out whether ​this filter makes sense or if there is a centralise point of registration of schemas in Core where I can just inline this.

[get_dave]

Is anyone able to advise how I fix the failing tests?

tests/qunit/fixtures/wp-api-generated.js

Example - ​https://github.com/WordPress/wordpress-develop/actions/runs/5331982052/jobs/9660558806?pr=4648

[kirasong]

Replying to get_dave:

Is anyone able to advise how I fix the failing tests?

If I understand correctly, this means that the fixtures need to be updated inside the PR / patch.

This is due to the test introduced in [51355].
More details on the ticket it's from: #53606

Looks like I need to add a new mock here 🤔

I think maybe we just need to regenerate qunit/fixtures/wp-api-generated.js?

npm run test:php -- --filter WP_Test_REST_Schema_Initialization

I'll take a look

Adds files relating to Navigation fallbacks for the block editor.

This PR brings ​https://github.com/WordPress/wordpress-develop/pull/4648 over in its entirity but with updated fixtures.

Props @getdave

Trac ticket: https://core.trac.wordpress.org/ticket/58557

With the updated fixtures in ​https://github.com/WordPress/wordpress-develop/pull/4713

LGTM

I'll have this one closed in favour of ​https://github.com/WordPress/wordpress-develop/pull/4713 and assign @getdave props

Thanks again, everyone!

Thank you!!

Closing in favour of ​https://github.com/WordPress/wordpress-develop/pull/4713

[audrasjb]

Converting to a task as this can ship after beta 1 is released.

committed in r56052 / ​3d551af

Following up on feedback from ​https://github.com/WordPress/wordpress-develop/pull/4713#pullrequestreview-1499992051

Let's use the found_posts ​property.

Props @mukeshpanchal27

Trac ticket: https://core.trac.wordpress.org/ticket/58557

Never mind, this doesn't work found_posts is 0 in the tests.

Will return for a follow up another time.

Updates original backport from https://core.trac.wordpress.org/ticket/58557 to also allow developers to opt out of the auto-creation of the fallback.

Why? Because if we automatically create something (even if it requires interaction with the WP site or editor) we should allow folks to opt out of that.

Trac ticket: https://core.trac.wordpress.org/ticket/58750

Committed in r56202 / ​a02886a.

[costdev]

This ticket was discussed during the bug scrub. @get_dave @isabel_brison As we are on 6.3 RC1 day, is there anything left to do on this for 6.3, or is it ready to close?

Backports the following Gutenberg PR:

• ​https://github.com/WordPress/gutenberg/pull/52758

cc @scruffian @getdave

Trac ticket: https://core.trac.wordpress.org/ticket/58557

[ramonopoly]

Re-opening for

​https://github.com/WordPress/wordpress-develop/pull/4891

[audrasjb]

PR approved for backport to branch 6.3 (second committer sign-off).

[isabel_brison]

In 56296:

Editor: load title on navigation fallback.

Adds raw title property when loading the navigation fallback with an embed context.

Props ramonopoly, get_dave, scruffian, mukesh27, audrasjb.
Fixes #58557.

[isabel_brison]

In 56297:

Editor: load title on navigation fallback.

Adds raw title property when loading the navigation fallback with an embed context.

Props ramonopoly, get_dave, scruffian, mukesh27, audrasjb.
Reviewed by audrasjb.
Merges [56296] to the 6.3 branch.
See #58557.

Committed in r56296 to trunk / r56297 to 6.3.