Make WordPress Core

Opened 11 months ago

Closed 10 months ago

Last modified 10 months ago

#58557 closed task (blessed) (fixed)

Backport: Navigation Fallbacks

Reported by: get_dave's profile get_dave Owned by: isabel_brison's profile isabel_brison
Milestone: 6.3 Priority: normal
Severity: normal Version:
Component: Editor Keywords: gutenberg-merge has-patch has-unit-tests dev-reviewed
Focuses: Cc:

Change History (31)

#1 @kebbet
11 months ago

  • Keywords gutenberg-merge added

#2 @flixos90
11 months ago

  • Milestone changed from Awaiting Review to 6.3
  • Type changed from defect (bug) to enhancement

This ticket was mentioned in PR #4648 on WordPress/wordpress-develop by @get_dave.


11 months ago
#3

  • Keywords has-patch added

Adds files relating to Navigation fallbacks for the block editor.

Trac ticket: https://core.trac.wordpress.org/ticket/58557

@spacedmonkey commented on PR #4648:


11 months ago
#4

@getdave Friendly reminder, changes like this need unit tests. Please ensure to backport / add unit tests.

@spacedmonkey commented on PR #4648:


11 months ago
#6

All classes, methods and function will need a @since 6.3.0.

@get_dave commented on PR #4648:


11 months ago
#7

@getdave Friendly reminder, changes like this need unit tests. Please ensure to backport / add unit tests.

Yep thanks. We have a suite already and I'm working out how/where to port them now.

I'm also trying to work out whether this filter makes sense or if there is a centralise point of registration of schemas in Core where I can just inline this.

#8 follow-up: @get_dave
11 months ago

Is anyone able to advise how I fix the failing tests?

tests/qunit/fixtures/wp-api-generated.js

Example - https://github.com/WordPress/wordpress-develop/actions/runs/5331982052/jobs/9660558806?pr=4648

Last edited 11 months ago by get_dave (previous) (diff)

#9 in reply to: ↑ 8 @kirasong
11 months ago

Replying to get_dave:

Is anyone able to advise how I fix the failing tests?

If I understand correctly, this means that the fixtures need to be updated inside the PR / patch.

This is due to the test introduced in [51355].
More details on the ticket it's from: #53606

@get_dave commented on PR #4648:


11 months ago
#10

Looks like I need to add a new mock here 🤔

@ramonopoly commented on PR #4648:


11 months ago
#11

I think maybe we just need to regenerate qunit/fixtures/wp-api-generated.js?

npm run test:php -- --filter WP_Test_REST_Schema_Initialization

I'll take a look

This ticket was mentioned in PR #4713 on WordPress/wordpress-develop by @ramonopoly.


11 months ago
#12

  • Keywords has-unit-tests added

Adds files relating to Navigation fallbacks for the block editor.

This PR brings https://github.com/WordPress/wordpress-develop/pull/4648 over in its entirity but with updated fixtures.

Props @getdave

Trac ticket: https://core.trac.wordpress.org/ticket/58557

@ramonopoly commented on PR #4648:


11 months ago
#13

With the updated fixtures in https://github.com/WordPress/wordpress-develop/pull/4713

LGTM

I'll have this one closed in favour of https://github.com/WordPress/wordpress-develop/pull/4713 and assign @getdave props

Thanks again, everyone!

@mikeschroder commented on PR #4648:


11 months ago
#14

Thank you!!

#16 @audrasjb
11 months ago

  • Type changed from enhancement to task (blessed)

Converting to a task as this can ship after beta 1 is released.

@isabel_brison commented on PR #4713:


11 months ago
#17

committed in r56052 / 3d551af

This ticket was mentioned in PR #4733 on WordPress/wordpress-develop by @ramonopoly.


11 months ago
#18

Following up on feedback from https://github.com/WordPress/wordpress-develop/pull/4713#pullrequestreview-1499992051

Let's use the found_posts property.

Props @mukeshpanchal27

Trac ticket: https://core.trac.wordpress.org/ticket/58557

@ramonopoly commented on PR #4733:


11 months ago
#19

Never mind, this doesn't work found_posts is 0 in the tests.

Will return for a follow up another time.

This ticket was mentioned in PR #4813 on WordPress/wordpress-develop by @get_dave.


11 months ago
#20

Updates original backport from https://core.trac.wordpress.org/ticket/58557 to also allow developers to opt out of the auto-creation of the fallback.

Why? Because if we automatically create something (even if it requires interaction with the WP site or editor) we should allow folks to opt out of that.

Trac ticket: https://core.trac.wordpress.org/ticket/58750

@isabel_brison commented on PR #4813:


11 months ago
#21

Committed in r56202 / a02886a.

This ticket was mentioned in Slack in #core by mukeshpanchal27. View the logs.


10 months ago

#23 @costdev
10 months ago

This ticket was discussed during the bug scrub. @get_dave @isabel_brison As we are on 6.3 RC1 day, is there anything left to do on this for 6.3, or is it ready to close?

#24 @isabel_brison
10 months ago

  • Resolution set to fixed
  • Status changed from new to closed

This ticket was mentioned in PR #4891 on WordPress/wordpress-develop by @ramonopoly.


10 months ago
#25

Backports the following Gutenberg PR:

cc @scruffian @getdave

Trac ticket: https://core.trac.wordpress.org/ticket/58557

#27 @isabel_brison
10 months ago

  • Keywords dev-feedback added
  • Resolution fixed deleted
  • Status changed from closed to reopened

#28 @audrasjb
10 months ago

  • Keywords dev-reviewed added; dev-feedback removed

PR approved for backport to branch 6.3 (second committer sign-off).

#29 @isabel_brison
10 months ago

  • Owner set to isabel_brison
  • Resolution set to fixed
  • Status changed from reopened to closed

In 56296:

Editor: load title on navigation fallback.

Adds raw title property when loading the navigation fallback with an embed context.

Props ramonopoly, get_dave, scruffian, mukesh27, audrasjb.
Fixes #58557.

#30 @isabel_brison
10 months ago

In 56297:

Editor: load title on navigation fallback.

Adds raw title property when loading the navigation fallback with an embed context.

Props ramonopoly, get_dave, scruffian, mukesh27, audrasjb.
Reviewed by audrasjb.
Merges [56296] to the 6.3 branch.
See #58557.

@isabel_brison commented on PR #4891:


10 months ago
#31

Committed in r56296 to trunk / r56297 to 6.3.

Note: See TracTickets for help on using tickets.