#58590 closed enhancement (fixed)
Add box shadow support to blocks in templates
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 6.3 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Editor | Keywords: | has-patch has-unit-tests gutenberg-merge changes-requested |
Focuses: | Cc: |
Description (last modified by )
Bring the support for shadow with in templates.
Following are the proposed supports.
<!-- wp:post-title {"shadow":"natural"} /--> <!-- wp:post-title {"style":{"shadow": "10px 10px 10px 10px #000"}} /-->
Note: The block must have the supports for "shadow" enabled for this to apply in the UI.
The solution has already been merged to Gutenberg here: https://github.com/WordPress/gutenberg/pull/46896
This ticket is to back-port these changes to the core.
Change History (8)
This ticket was mentioned in PR #4696 on WordPress/wordpress-develop by @ramonopoly.
21 months ago
#3
- Keywords has-patch has-unit-tests added
This PR is a continuation of https://github.com/WordPress/wordpress-develop/pull/4664 but adds tests
props to @madhusudhand
It adds the PHP changes for the following Gutenberg PRs:
https://github.com/WordPress/gutenberg/pull/46896
There are no front-end changes in this PR.
Testing instructions:
Enable supports for blocks such as post-title
src/wp-includes/blocks/post-title/block.json
{ ... "supports": { "shadow": true, ... }
In the theme template add shadow attribute as follows.
Verify the post title UI to have the applied shadow.
Trac ticket: https://core.trac.wordpress.org/ticket/58590
#4
@
21 months ago
- Keywords gutenberg-merge changes-requested added
- Milestone changed from Awaiting Review to 6.3
- Version trunk deleted
@ramonopoly Left some feedback on PR. Set the milestone 6.3
@ramonopoly commented on PR #4696:
21 months ago
#5
Thank you for the review @mukeshpanchal27 ! 🙇
@madhudollu commented on PR #4696:
21 months ago
#6
Thank you for adding the tests! @ramonjd
#58621 was marked as a duplicate.