WordPress.org
Get WordPress

Make WordPress Core

Changes between Version 2 and Version 3 of Ticket #58592, comment 6


Ignore:
Timestamp:
06/22/2023 09:36:02 AM (3 years ago)
Author:
talldanwp
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #58592, comment 6

    v2 v3  
    77
    88I noticed that if I change `page.waitForNavigation( { waitUntil: 'networkidle0' } ),` to `page.waitForNavigation(),` in the e2e test, then the test will pass, so possibly the change in the PR interferes with how Puppeteer detects network idle? I'm not entirely sure.
     9
     10edit: I haven't made any progress on this, though I've narrowed it down to `no-store` that causes the failing tests. `waitUntil: 'networkidle0'` means the test should wait until there are no active network requests, and that it fails indicates there is still an active network request. I haven't been able to spot any active ones when testing manually, so it is unusual.