Make WordPress Core

Opened 13 months ago

Closed 13 months ago

Last modified 13 months ago

#58651 closed defect (bug) (fixed)

Uncaught Error in 6.3-alpha-56081: Call to undefined function gutenberg_apply_colors_support()

Reported by: nendeb55's profile nendeb55 Owned by: bernhard-reiter's profile Bernhard Reiter
Milestone: 6.3 Priority: highest omg bbq
Severity: critical Version: 6.3
Component: Editor Keywords: has-patch
Focuses: Cc:

Description

wp_apply_colors_support() is correct.

wp-includes\blocks\navigation-submenu.php on line 204

Attachments (1)

58651.patch (947 bytes) - added by sabernhardt 13 months ago.

Download all attachments as: .zip

Change History (14)

#1 @nendeb55
13 months ago

The same applies to 6.3 Beta1

#2 @peterwilsoncc
13 months ago

  • Component changed from General to Editor
  • Milestone changed from Awaiting Review to 6.3
  • Priority changed from normal to highest omg bbq

Thanks for the report @nendeb55, I've moved this on the milestone to be actioned.

#3 @kebbet
13 months ago

  • Resolution set to reported-upstream
  • Status changed from new to closed

Will be solved in at least beta 2, see https://github.com/WordPress/gutenberg/pull/51989
But maybe included in Beta 1 due to the 24 hour delay (only guessing on my side).

#4 @sabernhardt
13 months ago

  • Resolution reported-upstream deleted
  • Status changed from closed to reopened

Reopening for any temporary fix or Gutenberg sync.

I was able to do a quick temporary fix with:

$colors_supports = function_exists( 'gutenberg_apply_colors_support' ) ? gutenberg_apply_colors_support( $block->block_type, $attributes ) : wp_apply_colors_support( $block->block_type, $attributes );

This ticket was mentioned in Slack in #core by sabernhardt. View the logs.


13 months ago

@sabernhardt
13 months ago

This ticket was mentioned in PR #4744 on WordPress/wordpress-develop by @costdev.


13 months ago
#7

  • Keywords has-patch added

This may have side-effects as it isn't accompanied by a packages update. However, no other instances of gutenberg_apply_colors_support appears in Core other than this instance. The rest appear to be the correct wp_apply_colors_support.

@spacedmonkey commented on PR #4748:


13 months ago
#9

@ockham CI seems to be failing :(

@Bernhard Reiter commented on PR #4748:


13 months ago
#10

@ockham CI seems to be failing :(

Dang. I think I need to npm run build to update the script loader file...

#11 @Bernhard Reiter
13 months ago

  • Owner set to Bernhard Reiter
  • Resolution set to fixed
  • Status changed from reopened to closed

In 56098:

Editor: Update npm packages to fix gutenberg_ prefix

Update @wordpress/* packages to the latest patch versions in
order to replace calls to gutenberg_apply_colors_support with
wp_apply_colors_support in order to avoid a fatal error.

Props joemcgill, spacedmonkey, flixos90, ironprogrammer, sabernhardt.
Fixes #58651.

#13 @sabernhardt
13 months ago

Added props to the commit. I may have missed someone in the Slack discussion.

From ticket: nendeb55, peterwilsoncc, kebbet, costdev
From Slack: bernhard-reiter (who belongs in props list even as the committer), davidbaumwald, SergeyBiryukov, desrosj, azaozz

Note: See TracTickets for help on using tickets.