Make WordPress Core

Opened 12 months ago

Closed 12 months ago

Last modified 5 months ago

#58667 closed defect (bug) (fixed)

Command Palette has no style applied

Reported by: wildworks's profile wildworks Owned by: isabel_brison's profile isabel_brison
Milestone: 6.3 Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch
Focuses: Cc:

Description

Originally reported in the Gutenberg project: https://github.com/WordPress/gutenberg/issues/52097

Command Palette, bundled into the core in WordPress 6.3, works as a feature but has no styles applied at all. Perhaps the enqueue of styles in script-loader.php is leaking.

Attachments (2)

actual.png (6.7 KB) - added by wildworks 12 months ago.
Actual behavior
expected.png (9.8 KB) - added by wildworks 12 months ago.
Expected behavior

Download all attachments as: .zip

Change History (6)

@wildworks
12 months ago

Actual behavior

@wildworks
12 months ago

Expected behavior

This ticket was mentioned in PR #4753 on WordPress/wordpress-develop by @wildworks.


12 months ago
#1

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/58667

As far as I can tell, the CSS for the command package for the Command Palette feature is bundled with the core. However, they do not appear to be enqueued.

✅ In the Site Editor, the CSS with id wp-commands-css should be enqueued

https://i0.wp.com/github.com/WordPress/wordpress-develop/assets/54422211/bebe7cd4-0281-42cc-96a1-ebe833e6986f

✅ In the Post Editor, the CSS with id wp-commands-css should be enqueued

https://i0.wp.com/github.com/WordPress/wordpress-develop/assets/54422211/26abaeb9-d6d0-4dd5-8933-d049ea666c54

✅ If the language is RTL, the CSS with id wp-commands-rtl-css should be enqueued

https://i0.wp.com/github.com/WordPress/wordpress-develop/assets/54422211/9bdf8ce0-0741-49a9-9557-f179ac9f7f48

✅ These CSS should not be enqueued in the Block Widget Editor and Customized Widget Editor

#2 @isabel_brison
12 months ago

  • Owner set to isabel_brison
  • Resolution set to fixed
  • Status changed from new to closed

In 56125:

Editor: Enqueue commands package styles.

Enqueues the stylesheet from the commands package which holds the CSS for the Command Palette feature.

Props wildworks.
Fixes #58667.

@isabel_brison commented on PR #4753:


12 months ago
#3

Committed in r56125 / 6aaf013.

#4 @swissspidy
5 months ago

  • Milestone changed from Awaiting Review to 6.3
Note: See TracTickets for help on using tickets.