Changes between Initial Version and Version 1 of Ticket #58673, comment 16
- Timestamp:
- 07/11/2023 10:48:33 PM (19 months ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #58673, comment 16
initial v1 1 I conducted server-side performance benchmarks for ([https://docs.google.com/spreadsheets/d/1PZAPCFQFhSjZFPNjeYW327pfyVFFM9m1_EkCNKA-pbc/edit see the results]): While it looks like the PR is improving performance overall, it is only a small overall difference (in the `wp-total` metric) of less than 1%. Interestingly, the PR makes the `wp-before-template` metric faster but the `wp-template` metric slower. It's almost as if the performance overhead is just being moved elsewhere.1 I conducted server-side performance benchmarks for https://github.com/WordPress/wordpress-develop/pull/4831 ([https://docs.google.com/spreadsheets/d/1PZAPCFQFhSjZFPNjeYW327pfyVFFM9m1_EkCNKA-pbc/edit see the results]): While it looks like the PR is improving performance overall, it is only a small overall difference (in the `wp-total` metric) of less than 1%. Interestingly, the PR makes the `wp-before-template` metric faster but the `wp-template` metric slower. It's almost as if the performance overhead is just being moved elsewhere. 2 2 3 3 I agree with the previous comments and with the approach of the PR. That said, the benchmark difference is too small to reliably confirm this as a regression. So I doubt that this change is what caused the overall regression that I shared in [comment:15].