Main navigation blue borders on the bottom of them and a blue border on the bottom of selected tabs

[hempsworth]

The main navigation tabs don't look completely right, with blue borders on the bottom of them and a blue border on the bottom of selected tabs. ​http://i243.photobucket.com/albums/ff32/hempsworth/tabs.jpg

Also, a strange bug in IE6 which causes a blue background/border on the current submenu item. ​http://i243.photobucket.com/albums/ff32/hempsworth/submenu.jpg

Both are fixed in the attached patch.

[hempsworth]

Patch for both bugs

[ryan]

Can you attach the image?

[hempsworth]

The tabs bug

[hempsworth]

The submenu IE6 bug

[Speedboxer]

I thought that border was intentional... Looks good with it. It also further distinguishes a tab you're hovering over, and a selected tab.

[hempsworth]

Before and after, with hover over

[hempsworth]

The attached image shows the tabs before and after the patch is applied, with an active and hovered over tab; I think this was the intended effect in the first place.

[hempsworth]

Oops, forgot to attach the 1x1px gif used as a background image!

[ryan]

(In [6880]) Tab styling fixes from hempsworth. fixes #5868

[Speedboxer]

The patch creates a double-underline in both IE7 and FF2. It's fine in Safari (for Windows), though.

[hempsworth]

Hmm, are you sure you did a hard refresh etc.
I just downloaded a fresh copy of trunk and it's working fine for me in:

• FF2
• Safari 3 (Windows)
• IE7
• IE6

Could you post a screenshot if the problem persists, thanks!

[Speedboxer]

What my tabs look like after this patch, in IE7 on Vista

[Speedboxer]

Replying to hempsworth:

Hmm, are you sure you did a hard refresh etc.
I just downloaded a fresh copy of trunk and it's working fine for me in:

• FF2
• Safari 3 (Windows)
• IE7
• IE6

Could you post a screenshot if the problem persists, thanks!

Yep, did a hard refresh, and reverted all modifications. I've attached a screenshot of what it looks like on the Dashboard (left) and what it looks like on the Write page with the mouse over Design (right). This is in IE7 on Vista, looks like same in FF2.

[ryan]

I had the double underline before, but the patch fixed it for FF2 and Safari on Mac. Go fig.

[Speedboxer]

Just checked it in IE6 on XP, same problem.

[Speedboxer]

Same problem in FF2 on XP and Opera on Vista.

[Speedboxer]

The latest patch fixes the double-underline. Just one more problem, the bottom of the hover box doesn't line up with the whole bottom border. If that makes sense.

[hempsworth]

Yep that makes sense :)
Try the revised version of double-underline-fix.patch

[Speedboxer]

Replying to hempsworth:

Yep that makes sense :)
Try the revised version of double-underline-fix.patch

I think either the whole border needs to be moved down a px, or the tabs need to be moved up a px...

[hempsworth]

The following patch is backtracking slightly and trying to fix:

the bottom of the hover box doesn't line up with the whole bottom border

...in a different way. Could you try this patch, and if it doesn't work, post a screenshot.

[Speedboxer]

Fix bugs in various browsers

[Speedboxer]

My patch fixes the problems. Except in Safari (for Windows) there's a small 1px gap between the bottom of the hover tab and the bottom border... I tested it in these browsers:

IE6 on XP
IE7 on Vista
Opera on Vista
FF2 on XP and Vista
Safari on Vista

[hempsworth]

Nice one, your patch works a treat!

[ryan]

(In [6884]) Tab styling fixes from Speedboxer. see #5868

[ryan]

(In [6885]) Removed no longer needed image. see #5868