WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#5868 closed defect (bug) (fixed)

Main navigation blue borders on the bottom of them and a blue border on the bottom of selected tabs

Reported by: hempsworth Owned by: hempsworth
Milestone: 2.5 Priority: low
Severity: normal Version: 2.5
Component: Administration Keywords: has-patch
Focuses: Cc:

Description

The main navigation tabs don't look completely right, with blue borders on the bottom of them and a blue border on the bottom of selected tabs. http://i243.photobucket.com/albums/ff32/hempsworth/tabs.jpg

Also, a strange bug in IE6 which causes a blue background/border on the current submenu item. http://i243.photobucket.com/albums/ff32/hempsworth/submenu.jpg

Both are fixed in the attached patch.

Attachments (8)

navigation-bugfix.patch (1.8 KB) - added by hempsworth 6 years ago.
Patch for both bugs
tabs.jpg (6.0 KB) - added by hempsworth 6 years ago.
The tabs bug
submenu.jpg (6.3 KB) - added by hempsworth 6 years ago.
The submenu IE6 bug
before-after.png (53.8 KB) - added by hempsworth 6 years ago.
Before and after, with hover over
admin-menu.gif (43 bytes) - added by hempsworth 6 years ago.
Oops, forgot to attach the 1x1px gif used as a background image!
patched-tabs.png (5.7 KB) - added by Speedboxer 6 years ago.
What my tabs look like after this patch, in IE7 on Vista
double-underline-fix.patch (408 bytes) - added by hempsworth 6 years ago.
5868.diff (1.1 KB) - added by Speedboxer 6 years ago.
Fix bugs in various browsers

Download all attachments as: .zip

Change History (30)

hempsworth6 years ago

Patch for both bugs

comment:1 hempsworth6 years ago

  • Owner changed from anonymous to hempsworth
  • Status changed from new to assigned

comment:2 lloydbudd6 years ago

  • Keywords has-patch added
  • Milestone changed from 2.6 to 2.5
  • Summary changed from Main navigation bugfix to Main navigation lue borders on the bottom of them and a blue border on the bottom of selected tabs
  • Version set to 2.5

comment:3 lloydbudd6 years ago

  • Summary changed from Main navigation lue borders on the bottom of them and a blue border on the bottom of selected tabs to Main navigation blue borders on the bottom of them and a blue border on the bottom of selected tabs

comment:4 ryan6 years ago

Can you attach the image?

hempsworth6 years ago

The tabs bug

hempsworth6 years ago

The submenu IE6 bug

comment:5 Speedboxer6 years ago

I thought that border was intentional... Looks good with it. It also further distinguishes a tab you're hovering over, and a selected tab.

hempsworth6 years ago

Before and after, with hover over

comment:6 hempsworth6 years ago

The attached image shows the tabs before and after the patch is applied, with an active and hovered over tab; I think this was the intended effect in the first place.

hempsworth6 years ago

Oops, forgot to attach the 1x1px gif used as a background image!

comment:7 ryan6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [6880]) Tab styling fixes from hempsworth. fixes #5868

comment:8 Speedboxer6 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

The patch creates a double-underline in both IE7 and FF2. It's fine in Safari (for Windows), though.

comment:9 follow-up: hempsworth6 years ago

Hmm, are you sure you did a hard refresh etc.
I just downloaded a fresh copy of trunk and it's working fine for me in:

  • FF2
  • Safari 3 (Windows)
  • IE7
  • IE6

Could you post a screenshot if the problem persists, thanks!

Speedboxer6 years ago

What my tabs look like after this patch, in IE7 on Vista

comment:10 in reply to: ↑ 9 Speedboxer6 years ago

Replying to hempsworth:

Hmm, are you sure you did a hard refresh etc.
I just downloaded a fresh copy of trunk and it's working fine for me in:

  • FF2
  • Safari 3 (Windows)
  • IE7
  • IE6

Could you post a screenshot if the problem persists, thanks!

Yep, did a hard refresh, and reverted all modifications. I've attached a screenshot of what it looks like on the Dashboard (left) and what it looks like on the Write page with the mouse over Design (right). This is in IE7 on Vista, looks like same in FF2.

comment:11 ryan6 years ago

I had the double underline before, but the patch fixed it for FF2 and Safari on Mac. Go fig.

comment:12 Speedboxer6 years ago

Just checked it in IE6 on XP, same problem.

comment:13 Speedboxer6 years ago

Same problem in FF2 on XP and Opera on Vista.

comment:14 Speedboxer6 years ago

The latest patch fixes the double-underline. Just one more problem, the bottom of the hover box doesn't line up with the whole bottom border. If that makes sense.

comment:15 follow-up: hempsworth6 years ago

Yep that makes sense :)
Try the revised version of double-underline-fix.patch

comment:16 in reply to: ↑ 15 Speedboxer6 years ago

Replying to hempsworth:

Yep that makes sense :)
Try the revised version of double-underline-fix.patch

I think either the whole border needs to be moved down a px, or the tabs need to be moved up a px...

comment:17 hempsworth6 years ago

The following patch is backtracking slightly and trying to fix:

the bottom of the hover box doesn't line up with the whole bottom border

...in a different way. Could you try this patch, and if it doesn't work, post a screenshot.

Speedboxer6 years ago

Fix bugs in various browsers

comment:18 Speedboxer6 years ago

My patch fixes the problems. Except in Safari (for Windows) there's a small 1px gap between the bottom of the hover tab and the bottom border... I tested it in these browsers:

IE6 on XP
IE7 on Vista
Opera on Vista
FF2 on XP and Vista
Safari on Vista

comment:19 hempsworth6 years ago

Nice one, your patch works a treat!

comment:20 ryan6 years ago

(In [6884]) Tab styling fixes from Speedboxer. see #5868

comment:21 ryan6 years ago

(In [6885]) Removed no longer needed image. see #5868

comment:22 ryan6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.