Cast return value to int in functions that use ceil()

[crstauf]

The use-case expects an integer to be returned, but the count() function returns a float; cast the returned value to an integer.

• get_comment_pages_count()
• wp_embed_defaults()
• get_oembed_response_data()

This was mentioned by Sergey in https://core.trac.wordpress.org/ticket/55654#comment:9, and subsequent ticket #56800 aimed to update the tests, but the functions do not appear to have been fixed.

Handful of functions use ceil(), which returns a float, but the functions expect an integer. Change those functions to cast ceil() to an integer.

Trac ticket: https://core.trac.wordpress.org/ticket/58683

[crstauf]

Reported by @wileycoyote78 in User Contributed Notes.

[audrasjb]

Looks good to me, thanks!
Moving for 6.5 consideration.

Looks like Performance tests are failing with this change 👀

Supersedes ​https://github.com/WordPress/wordpress-develop/pull/4768 as it addresses more places as mentioned originally at https://core.trac.wordpress.org/ticket/55654#comment:9

Trac ticket: https://core.trac.wordpress.org/ticket/58683

[swissspidy]

In 57648:

General: Consistently cast return value to int in functions that use ceil().

The return value of ceil() is still of type float as the value range of float is usually bigger than that of int.

Props crstauf, audrasjb.
Fixes #58683.

Fixed in https://core.trac.wordpress.org/changeset/57648

Committed in https://core.trac.wordpress.org/changeset/57648

[SergeyBiryukov]

In 57650:

Tests: Use assertSame() in get_comment_pages_count() tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Follow-up to [27055], [48937], [54402], [57244], [57648].

Props costdev.
See #58683, #59655.

[SergeyBiryukov]

In 57653:

Tests: Use assertSame() in WP_Query tests involving ::$max_num_pages property.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Follow-up to [48937], [54402], [54768], [57648].

Props costdev.
See #58683, #59655.